74263[TASK] Log more context for failed DataHandler evaluations
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Jörg Bösche +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1318
-
Nikita Hovratov uploaded patch set 1 04/09/22, 09:04
-
core-ci voted on patch set 1 V +1 04/09/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25876
-
Stefan Bürk commented on patch set 1 04/09/22, 09:48
DataHandler.php:1998Hard using the $field is not feasonable. $field may be empty. Should be checked and used conditional wise. (Not sure about table name). From docblock of "checkValue_SW(..)" calling this method: ``` Can be called for FlexForm pseudo fields as well, BUT must not have $field set if so. ```DataHandler.php:1999see comment line aboveDataHandler.php:2004same here as above -
Nikita Hovratov commented on patch set 1 V -1 04/09/22, 11:20
DataHandler.php:1799ReplyAck -
Nikita Hovratov uploaded patch set 2 04/09/22, 12:10
-
Nikita Hovratov commented on patch set 2 04/09/22, 12:13
DataHandler.php:1998ReplyHow about this approach I just pushed: If the field is empty, it is treated as a FlexForm field and the name of the FlexForm field is used instead. Doesn't give us exactly the path inside the flexForm field, but better than nothing. -
core-ci voted on patch set 2 V -1 04/09/22, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25879
-
Nikita Hovratov uploaded patch set 3 04/09/22, 12:32
-
core-ci voted on patch set 3 V -1 04/09/22, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25881
-
Nikita Hovratov uploaded patch set 4 04/09/22, 18:30
-
core-ci voted on patch set 4 V +1 04/09/22, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25884
-
Nikita Hovratov uploaded patch set 5 04/09/22, 19:44
-
core-ci voted on patch set 5 V +1 04/09/22, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25886
-
Stefan Bürk commented on patch set 5 V +1 CR +1 04/09/22, 20:56
Thanks for taking care of the comments.DataHandler.php:1998ReplyDoneDataHandler.php:1999ReplyDoneDataHandler.php:2004ReplyDone -
Susi Moog voted on patch set 5 CR +1 04/12/22, 16:16
-
Jörg Bösche voted on patch set 5 CR +1 04/14/22, 09:00
-
Benni Mack voted on patch set 5 V +2 CR +2 04/14/22, 20:39
-
Benni Mack merged patch set 6 04/14/22, 20:39
DataHandler.php:1799