Review main Abandoned

74266[POC][BUGFIX] Collect site route candidates with priorization

Stefan Bürk CR 0 V 0 Normal +199 −19 updated 11/09/22, 09:24

Commit message

... testing out different alternative approaches

Adjusted two docblock variable types in testcase which
solves one phpstan ignore pattern along the way.

used commands:

> Build/Scripts/runTests -s phpstanGenerateBaseline

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1830

Show 45 earlier messages
  1. Stefan Bürk uploaded patch set 1 04/10/22, 13:44

  2. Stefan Bürk wrote 04/10/22, 13:44

    Removed cc Tomek Woldański.
  3. core-ci voted on patch set 1 V -1 04/10/22, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25901

  4. Stefan Bürk uploaded patch set 2 04/10/22, 14:10

  5. Stefan Bürk updated the commit message in patch set 3 04/10/22, 14:13

  1. Stefan Bürk uploaded patch set 4 04/10/22, 14:20

  2. Stefan Bürk wrote 04/10/22, 14:21

    Removed cc Tomek Woldański.
  3. Stefan Bürk uploaded patch set 5 04/10/22, 14:23

  4. core-ci voted on patch set 2 V -1 04/10/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25904

  5. core-ci voted on patch set 3 V -1 04/10/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25905

  6. core-ci voted on patch set 4 V -1 04/10/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25906

  7. core-ci voted on patch set 5 V -1 04/10/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25907

  8. Stefan Bürk uploaded patch set 6 04/10/22, 15:11

  9. core-ci voted on patch set 6 V +1 04/10/22, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25909

  10. Stefan Bürk updated the commit message in patch set 7 04/10/22, 15:21

  11. Stefan Bürk updated the commit message in patch set 8 04/10/22, 15:22

  12. core-ci voted on patch set 7 V +1 04/10/22, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25910

  13. core-ci voted on patch set 8 V +1 04/10/22, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25911

  14. Stefan Bürk updated the commit message in patch set 9 04/10/22, 18:02

  15. core-ci voted on patch set 9 V +1 04/10/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25912

  16. Oliver Hader commented on patch set 9 04/11/22, 07:50

    This change makes a complicated (not complex) scenario even more complicated...

    SiteMatcher.php:226

    That's too specific... ambiguity also can be e.g. `/blog/`, `/blog/de/`, `/blog/fr/`..

    SiteMatcher.php:265

    Looks like bitmask with special mapping...
  17. Oliver Hader commented on patch set 9 04/11/22, 07:51

  18. Stefan Bürk commented on patch set 9 04/11/22, 08:25

    SiteMatcher.php:226 Reply Unresolved

    That check was to check if site <-> siteLanguage has the same path. Independent if site->path has a path or not (subfolder install, custom path to separate, ...). So non matching siteLanguage has higher preceedence, than the matching nad the site with the lowest.

    SiteMatcher.php:265 Reply Unresolved

    Yes. Forgot to add a @todo - how this check and calcualtion is done was not really part of the "POC" - was more a implementation to have some kind of definition for it. The POC was more about the general "priorize the routes during collection"
  19. Stefan Bürk uploaded patch set 10 04/11/22, 17:22

  20. Stefan Bürk uploaded patch set 11 04/11/22, 17:24

  21. core-ci voted on patch set 10 V -1 04/11/22, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25931

  22. core-ci voted on patch set 11 V -1 04/11/22, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25932

  23. Stefan Bürk uploaded patch set 12 04/11/22, 17:36

  24. core-ci voted on patch set 12 V +1 04/11/22, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25933

  25. Oliver Hader abandoned the change 11/09/22, 09:24