Review main Merged

74268[DOCS] Remove superfluous sendmail option in smtp configuration example

TYPO3com CR +2 V +2 Easy +0 −1 updated 04/12/22, 15:08

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Björn Jacob +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Björn Jacob +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. TYPO3com uploaded patch set 1 04/10/22, 18:33

  2. Josef Glatz updated the commit message in patch set 2 04/10/22, 18:34

  3. core-ci voted on patch set 2 V +1 04/10/22, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25916

  4. Josef Glatz voted on patch set 2 V +1 CR +1 04/10/22, 18:47

  5. core-ci voted on patch set 1 V +1 04/10/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25915

  6. Stefan Bürk commented on patch set 2 V +1 CR +1 04/10/22, 19:37

    Thanks, good catch. Small side-note for the future: Granted, it's a simple doc changes. Author of patches should not vote on their own patches. Even if they "slip" them in as github pull-request. Don't let it become standard behaviour. See: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/HandlingAPatch/Review.html#policy-for-votes ``` Authors should not vote for their own patches, unless the patch has been changed substantially by other developers. ```
  7. Björn Jacob voted on patch set 2 V +1 CR +1 04/11/22, 07:30

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 04/12/22, 15:08

  9. Oli Bartsch merged patch set 3 04/12/22, 15:08