Review main Merged

74283[BUGFIX] Prevent PHP warnings in workspace ActionHandler

Oli Bartsch CR +2 V +2 Easy +9 −9 updated 04/14/22, 16:20

Commit message

* $parameters->additional might not be set,
   depending on the workspace configuration
* There might be no "next" or "prev" stage,
   depending on the current stage

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 04/13/22, 09:34

  2. core-ci voted on patch set 1 V +1 04/13/22, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25972

  3. Oliver Klee voted on patch set 1 CR +1 04/13/22, 10:11

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/13/22, 13:52

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/13/22, 17:56

  6. Benni Mack voted on patch set 1 V +1 CR +1 04/14/22, 16:19

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 04/14/22, 16:20

  8. Oli Bartsch merged patch set 2 04/14/22, 16:20