Review 10.4 Merged

74294[DOCS] Rename undeclared argument "length" to "maxCharacters"

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/12/22, 16:53

Commit message

The CropViewHelper does not have a "length" argument, but the
"maxCharacters" argument is mandatory. From the context it is clear that
the wrong argument was accidentally used here and that this needs to be
renamed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch commented on patch set 1 04/12/22, 15:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/12/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25958

  3. Oliver Klee voted on patch set 1 CR +1 04/12/22, 16:03

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 04/12/22, 16:53

  5. Oli Bartsch merged patch set 2 04/12/22, 16:53