Review main Merged

74318[BUGFIX] Fix sorting of file properties in FileList

Oli Bartsch CR +2 V +2 Normal +155 −66 updated 04/22/22, 09:47

Commit message

Since the introduction of the column selector to the
FileList (#96959), it had been possible to sort by
all those selected columns. However, this actually
never worked, because the sorting was done in the
driver (e.g. LocalDriver), which does not know
anything about the file (metadata) properties.
This is also the reason why sorting of folders
always just lead them to jump around.

To fix this, sorting is now done in the FileList,
where working on the file/folder objects directly
is possible. This also now finally ensures that
the displayed value is the same value which is
used for sorting. This previously was not always
the case, see e.g. #97261 or #97290.

Additionally, this patch fixes some further sorting
related bugs, e.g. the control column header is no
longer wrapped into a sort link.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1