Review main Merged

74322[TASK] Use File constants in sys_file TCA file

Nikita Hovratov CR +2 V +2 Easy +11 −11 updated 04/16/22, 03:49

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Christoph Schwob +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christoph Schwob +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 04/15/22, 08:21

  2. core-ci voted on patch set 1 V +1 04/15/22, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26048

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 04/15/22, 08:52

  4. Oliver Klee voted on patch set 1 CR +1 04/15/22, 09:19

  5. Christoph Schwob voted on patch set 1 V +1 CR +1 04/15/22, 15:12

  6. Benjamin Franzke commented on patch set 1 V +2 CR +2 04/16/22, 03:49

    sys_file.php:14

    For a moment I stumbled over the string-to-integer conversion in here, therefore I'll mention this explicitly: A key like '1' is stored as integer by PHP anyway. So changing the keys from '1' to 1 is actually fine, as PHP doesn't support strict types for array keys (unfortunately).
  7. Benjamin Franzke merged patch set 2 04/16/22, 03:49