Review main Merged

74328[TASK] Use constants in NewMultiplePagesController

Benni Mack CR +2 V +2 Easy +16 −18 updated 04/16/22, 10:46

Commit message

This change uses constants from PageRepository
to define possible doktypes.

In addition, some minor details in the rest
of the code (strict types, variable renaming)
help to understand the code better.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 04/15/22, 23:34

  2. core-ci voted on patch set 1 V +1 04/15/22, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26081

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 04/16/22, 02:50

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/16/22, 08:10

  5. Oliver Klee voted on patch set 1 CR +1 04/16/22, 08:12

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/16/22, 10:46

  7. Benni Mack merged patch set 2 04/16/22, 10:46