74340[BUGFIX] Fix the generics annotations of makeInstance
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1214
-
Oliver Klee uploaded patch set 1 04/18/22, 10:21
-
core-ci voted on patch set 1 V -1 04/18/22, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26137
-
Oliver Klee commented on patch set 1 04/18/22, 10:41
The CI failures seem to be unrelated to my changes. -
Stefan Bürk commented on patch set 1 04/18/22, 10:55
Reply
Retry started. -
core-ci voted on patch set 1 V +1 04/18/22, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26137
-
Simon Schaufelberger voted on patch set 1 CR +1 04/21/22, 21:55
-
Nikita Hovratov voted on patch set 1 V +1 CR +1 04/24/22, 19:40
-
Simon Schaufelberger commented on patch set 1 04/25/22, 10:35
where is this documented? I looked on phpdoc website and didn't find anything about it -
Oliver Klee commented on patch set 1 04/25/22, 10:49
Reply
It's documented here: https://phpstan.org/blog/generics-by-examples (Concerning type annotations, the PHPStan and Psalm documentation are a better source than the PHPDoc website as far as I can tell.) -
Simon Schaufelberger voted on patch set 1 V +1 04/25/22, 11:27
-
Stefan Bürk voted on patch set 1 V +2 CR +2 04/25/22, 11:34
-
Stefan Bürk merged patch set 2 04/25/22, 11:34
-
Netresearch DTT GmbH commented on patch set 2 02/01/23, 06:26
Due this change phpstan now fails with, e.g. `Call to an undefined method object::getQueryBuilderForTable().` -
Oliver Klee commented on patch set 2 02/01/23, 09:29
Reply
In the Core, there are no new PHPStan warnings caused by this change (as otherwise the build would not pass). Could you please open a ticket on Forge with the code necessary to reproduce the problem? Thanks!