Review main Merged

74351[TASK] Improve a type annotation in the setup extension

Oliver Klee CR +2 V +2 Easy +3 −14 updated 06/02/22, 11:32

Commit message

Also add a missing type cast.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1619

  1. Oliver Klee uploaded patch set 1 04/18/22, 17:34

  2. core-ci voted on patch set 1 V +1 04/18/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26162

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/19/22, 19:56

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/19/22, 21:20

  5. Nikita Hovratov commented on patch set 1 V -1 04/24/22, 19:04

    Seems that the parameter is always a string. Should we change it to numeric-string|''|'delete' instead?
  6. Oliver Klee commented on patch set 1 04/24/22, 19:34

    Reply

    Thanks! That's not how I read the code, though. I'll recheck in detail and the report back (and update the code if necessary).
  7. Nikita Hovratov commented on patch set 1 04/24/22, 19:44

    Reply

    Found it out through debugging. As the data comes directly from the Request object there is no type conversion whatsoever and thus always a string.
  8. Oliver Klee marked it work in progress 04/25/22, 10:52

  9. Oliver Klee uploaded patch set 2 05/28/22, 13:23

  10. Oliver Klee marked it ready for review 05/28/22, 13:24

  11. Oliver Klee commented on patch set 2 05/28/22, 13:24

    Reply

    Thanks! Done.
  12. core-ci voted on patch set 2 V +1 05/28/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27514

  13. Oliver Klee uploaded patch set 3 05/28/22, 13:36

  14. core-ci voted on patch set 3 V +1 05/28/22, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27515

  15. Stefan Bürk voted on patch set 3 V +1 CR +1 05/28/22, 21:07

  16. Simon Schaufelberger voted on patch set 3 V +1 CR +1 05/30/22, 15:09

  17. Stefan Bürk voted on patch set 3 V +2 CR +2 06/02/22, 11:24

  18. Stefan Bürk merged patch set 4 06/02/22, 11:24

  19. Oliver Hader voted on patch set 4 CR +1 06/02/22, 11:32