Review main Merged

74352[BUGFIX] Use proper EventDispatcherInterface mock

Stefan Bürk CR +2 V +2 Easy +30 −5 updated 04/18/22, 23:26

Commit message

Introducing two new PSR-14 events with #96975 added corresponding tests
with prophesized EventDispatcherInterface objects. This works on core ci
and locally until a real instance with installed styleguide data and
site configurations exists. SiteConfigurations will be looped and the
called prophesized EventDispatcher returned null instead of an event,
emitting a php error.

This patch uses proper anonymous class mocks which simply return the
given event to avoid this issue.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2