Review main Merged

74359[TASK] Drop typo3/phar-stream-wrapper due to improved handling in PHP

Oliver Hader CR +2 V +2 Hard +2 −564 updated 04/20/22, 11:40

Commit message

PHP 8.0 finally dropped automatic deserialization of Phar metadata
(see https://wiki.php.net/rfc/phar_stop_autoloading_metadata). That's
why our corresponding stream guard `typo3/phar-stream-wrapper` can
be removed from being initialized with every request & invocation.

https://github.com/typo3/phar-stream-wrapper

Thank you and goodbye, dear PharStreamWrapper!
You've been a great help to us.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1417

  1. Oliver Hader uploaded patch set 1 04/19/22, 19:09

  2. core-ci voted on patch set 1 V -1 04/19/22, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26200

  3. Oliver Hader uploaded patch set 2 04/19/22, 19:22

  4. core-ci voted on patch set 2 V +1 04/19/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26201

  5. Benni Mack voted on patch set 2 V +1 CR +1 04/19/22, 19:45

  6. Markus Klein voted on patch set 2 CR +1 04/19/22, 19:45

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 04/20/22, 00:01

  8. Oliver Hader commented on patch set 2 CR -1 04/20/22, 07:17

    I don't like the farewell message... sounds German-English...
  9. Oliver Hader updated the commit message in patch set 3 04/20/22, 07:36

  10. Susi Moog voted on patch set 3 CR +1 04/20/22, 07:37

  11. core-ci voted on patch set 3 V +1 04/20/22, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26220

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 04/20/22, 07:55

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 04/20/22, 08:12

  14. Georg Ringer commented on patch set 3 04/20/22, 08:33

    can we skip its usage also in 11 if PHP8+ is used?
  15. Oliver Hader voted on patch set 3 V +2 CR +2 04/20/22, 11:30

  16. Benni Mack voted on patch set 3 V +1 CR +1 04/20/22, 11:39

  17. Oliver Hader merged patch set 4 04/20/22, 11:40