74369[BUGFIX] Use the correct pluralized key in search results
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
crell uploaded patch set 1 04/21/22, 16:15
-
core-ci voted on patch set 1 V +1 04/21/22, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26279
-
Simon Schaufelberger voted on patch set 1 CR +1 04/21/22, 21:45
-
Stefan Bürk commented on patch set 1 V +1 CR +1 04/22/22, 16:16
Note for other reviewers how to test it (verify): Given monorepo + styleguide installed and setup correctly (maybe need to add a typoscript for it, another issue). * upload a pdf/multiple pdfs (single/multiple pages) to the storage / upload folder * add it for example on "upload" page the styleguide frontend tree as irre relation to the content element * reload the page in the frontend so it get's indexed (the pdf file) * open the list page of the styleguide frontend and search for the "name" of the file ... Then you can se it in the result: ``` Before: 'page 1-18' After: 'pages 1-18' ``` for example. -
Henrik Elsner voted on patch set 1 CR +1 04/26/22, 11:18
-
Jörg Bösche voted on patch set 1 CR +1 04/27/22, 11:10
-
Oli Bartsch commented on patch set 1 04/27/22, 15:47
Does this not affect 11.5? - Issue was created for v10. -
Simon Schaufelberger commented on patch set 1 V +1 CR -1 04/28/22, 01:05
add 11.5 as well -
Stefan Bürk updated the commit message in patch set 2 04/28/22, 07:45
-
core-ci voted on patch set 2 V +1 04/28/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26552
-
Stefan Bürk voted on patch set 2 V +1 CR +1 04/28/22, 08:02
-
Oli Bartsch voted on patch set 2 V +2 CR +2 04/28/22, 10:22
-
Oli Bartsch merged patch set 3 04/28/22, 10:22