Review main Merged

74370[BUGFIX] Only show pagination indicator if there are multiple pages

crell CR +2 V +2 Easy +7 −5 updated 06/27/22, 10:41

Commit message

The search results page currently may show the "pages"
indicator in the title when there are no page numbers
to show. This patch changes it to only show pagination
information if there is information to show.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Kevin Meier +1
    • crell +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Kevin Meier +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1722

  1. crell uploaded patch set 1 04/21/22, 16:15

  2. core-ci voted on patch set 1 V +1 04/21/22, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26280

  3. Simon Schaufelberger voted on patch set 1 CR +1 05/27/22, 15:42

  4. Stefan Bürk updated the commit message in patch set 2 06/07/22, 10:00

  5. Stefan Bürk rebased onto patch set 3 06/07/22, 10:01

  6. core-ci voted on patch set 2 V -1 06/07/22, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27764

  7. core-ci voted on patch set 2 V -1 06/07/22, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27764

  8. core-ci voted on patch set 3 V +1 06/07/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27765

  9. Stefan Bürk commented on patch set 3 CR -1 06/07/22, 11:30

    This patch does not do/change anything. However, I do not really get the issue itself. ``` The else block should only be executed if static_page_arguments is not empty as the addition to the title makes no sense without any additional (page) information. ``` Not sure how this should be interpreted or what `static_page_arguments` should be. Single page PDF is displayed correctly with "page 1" and pdfs with multiple pages correspondingly splitted. Should this patch target to avoid "page 1" if there is only one page ? Than this do not work. Giving -1 as this patch does nothing, at least as someone can describe to properly test this.
  10. Stefan Bürk commented on patch set 3 06/07/22, 11:31

    Reply

    Maybe someone can come up how to verify this.
  11. Stefan Bürk commented on patch set 3 06/13/22, 16:08

    Reply

    Tried again with differend PDF's. Tested with "excel sheet", but there are other issues (array access arrays). Patch will follow. For this one, would be really nice to have a case to reproduce the issue and verify the patch is working.
  12. Stefan Bürk commented on patch set 3 06/13/22, 16:15

    SearchController.php:478

    If the case may be reproducable (not found a way yet), this should be properly guarded: ``` if (is_array($dat) && !empty($dat['key'])) { ```
  13. Stefan Bürk uploaded patch set 4 06/13/22, 16:52

  14. Kevin Meier voted on patch set 3 V +1 CR +1 06/13/22, 16:52

  15. Stefan Bürk commented on patch set 4 V +1 CR +1 06/13/22, 16:54

    Reply

    It's hard to switch installation etc and reset indexing in current state. However, it is possible that entries get indexed without the json data (null or empty string), thus this additionally check is okay for these cases. It seems that it boiles down to missing tool or error through indexing or old indexing data. Thus changes voting to +1/+1. Note: Deleting indexed data entries from backend currently not possible through another error, out of the scope of this patch.

    SearchController.php:478 Reply

    Done
  16. core-ci voted on patch set 4 V +1 06/13/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28021

  17. Simon Schaufelberger wrote 06/13/22, 19:16

    Removed reviewer Simon Schaufelberger.
  18. Kevin Meier voted on patch set 4 V +1 CR +1 06/14/22, 08:11

  19. crell voted on patch set 4 CR +1 06/14/22, 14:44

  20. Jörg Bösche voted on patch set 4 CR +1 06/24/22, 19:19

  21. Stefan Bürk voted on patch set 4 V +2 CR +2 06/27/22, 10:41

  22. Stefan Bürk merged patch set 5 06/27/22, 10:41