Review main Abandoned

74391[BUGFIX] PageCopy with nested ContentElements(GridElements) l10n_source is

Alex Ebeling-Hoppe CR 0 V 0 Easy +1 −1 updated 12/04/24, 11:26

Commit message

now set to correct uid

Fixes order for copying nested indented content elements to get correct
values for l10n_source of translated CE's on a copied page.
See https://forge.typo3.org/issues/97469 for more information.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 710

  1. Alex Ebeling-Hoppe uploaded patch set 1 04/25/22, 19:16

  2. Alex Ebeling-Hoppe updated the commit message in patch set 2 04/25/22, 19:23

  3. core-ci voted on patch set 1 V -1 04/25/22, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26413

  4. core-ci voted on patch set 2 V -1 04/25/22, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26415

  5. Stefan Bürk commented on patch set 2 04/25/22, 19:56

    Unresolved

    Thank you for your first patch. See the comment at the place you changed. Some notes generally: Your fix breaks quite some tests. Thus the red pipeline/core-ci. So at first, this indicates that your change has more effect than eventually thought. In the end, do not get the issue completly yet .. so could not help atm. Will have a look the next days or so if no one is quicker. If you need help how to identify the failing tests or how to run them locally, you can ask in slack in the #typo3-cms-coredev channel.

    DataHandler.php:3672 Unresolved

    Not really sure if this is really the fix. On the other hand do not fully understand your/the issue fully yet. However, there are quite some tests testing a lot of the datahandler. This change now let's quite some of them fail. Meaning that expected outcome has changed for the defined test cases. So the first step would be to create a test for your usecase, which would be red. And then try to locate the place and try to fix it - without breaking other tests. If there are tests which are wrong, they may be adjusted/changed correspondingly.
  6. Benni Mack commented on patch set 2 04/14/23, 10:02

    any update here? As v10.4 will soon be out of our support, we should adapt or abandon this change.
  7. Benni Mack updated the commit message in patch set 3 V -1 05/03/23, 09:44

  8. Benni Mack updated the commit message in patch set 4 10/18/24, 14:06

  9. core-ci voted on patch set 4 V -1 10/18/24, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68124

  10. Benni Mack abandoned the change 12/04/24, 11:26

    abandoning this change as mentioned before