Review 11.5 Merged

74392[BUGFIX] Name invalid identifier in UpgradeWizard exception

Helmut Hummel CR +2 V +2 Easy +11 −2 updated 05/04/22, 20:34

Commit message

An exception will be raised, if an upgrade wizard identifier
returned by "UpgradeWizardInterface::getIdentifier()" is not
valid due to e.g. misspelling.

The invalid identifier is now mentioned in the exception
message for easier debugging.

In addition, the exception is now split up into two separate
exceptions in order to define the reason more precisely.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Helmut Hummel commented on patch set 1 04/23/22, 17:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 04/23/22, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26350

  3. Stefan Bürk commented on patch set 1 04/23/22, 22:27

    pipeline hickup (cloud runner ssl/git clone issue). started retry.
  4. core-ci voted on patch set 1 V +1 04/23/22, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26350

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 04/23/22, 22:28

  6. Oliver Klee voted on patch set 1 CR +1 04/27/22, 15:37

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 05/04/22, 20:34

  8. Oli Bartsch merged patch set 2 05/04/22, 20:34