Review 11.5 Merged

74396[BUGFIX] Check parsed option in EmailFinisher

Oli Bartsch CR +2 V +2 Easy +4 −0 updated 04/25/22, 20:02

Commit message

To prevent PHP warnings for passing invalid
arguments to "foreach", the parsed option
is now checked to be a non empty array.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Oli Bartsch commented on patch set 1 04/25/22, 19:24

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 04/25/22, 19:32

  3. core-ci voted on patch set 1 V -1 04/25/22, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26418

  4. core-ci voted on patch set 1 V +1 04/25/22, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26418

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 04/25/22, 20:02

  6. Oli Bartsch merged patch set 2 04/25/22, 20:02