Review 11.5 Merged

74437[BUGFIX] Prevent undefined array key warnings in PageRenderer

Oli Bartsch CR +2 V +2 Easy +13 −13 updated 04/26/22, 19:14

Commit message

Since JS and CSS related properties might be
modified by hooks, corresponding array access
is now secured using null coalescing operators.
This was actually already done for the majority
of those places.

Note: Some places might not make sense to
fallback, e.g. empty css code or empty JS
file paths. However, this should be handled
in a separate patch, and for main only.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch uploaded patch set 1 04/26/22, 18:45

  2. core-ci voted on patch set 1 V +1 04/26/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26469

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 04/26/22, 19:14

  4. Oli Bartsch merged patch set 2 04/26/22, 19:14