Review main Merged

74440[TASK] Add property and return types to EventDispatcher

crell CR +2 V +2 Easy +6 −11 updated 04/27/22, 10:20

Commit message

The object return on dispatch() is not a formal part of
the interface for BC reasons, but is required by the spec,
so thanks to LSP it's safe to add this way, and recommended.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. crell uploaded patch set 1 04/26/22, 20:56

  2. core-ci voted on patch set 1 V -1 04/26/22, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26481

  3. core-ci voted on patch set 1 V +1 04/26/22, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26481

  4. Oliver Klee voted on patch set 1 CR +1 04/26/22, 21:48

  5. Benjamin Franzke voted on patch set 1 V +1 CR +1 04/27/22, 06:40

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/27/22, 10:20

  7. Benni Mack merged patch set 2 04/27/22, 10:20