74446[FEATURE] Show Symfony expression language providers in config module
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Chris Müller +1
- Oliver Klee +1
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Chris Müller +1
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97480-SymfonyExpressionLanguageProvidersAvailableInConfigurationModule.rstnew+17 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SymfonyExpressionLanguageProvidersProvider.php2new+63 −0
- typo3/sysext/lowlevel/Configuration/Services.yaml+8 −0
- typo3/sysext/lowlevel/Documentation/BackendModules/Configuration.rst+1 −0
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+3 −0
Review log 3746
Show 1821 earlier messages
-
Georg Ringer uploaded patch set 1 04/27/22, 14:31
-
Georg Ringer commented on patch set 1 04/27/22, 14:31
This change is ready for review. -
core-ci voted on patch set 1 V +1 04/27/22, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26513
-
Oli Bartsch commented on patch set 1 04/27/22, 16:10
I thought about the forge issue already and came to the conclusion that it's IMO not a good idea to add more and more of those providers. The list is already quite huge (compared to previous versions). I'm actually not even convinced about #96152 anymore. I think only "important" providers (events, middlewares, TCA, ..) should be supplied by Core. With the API (introduced in #92929) extension authors can easily add their own providers if a specific registry is interesting to them. What do you think? -
Oli Bartsch commented on patch set 1 04/27/22, 16:21
Reply
The main problem I see is that Core contains an uncountable amount of such registries. Anything like context menu providers, dashboard widgets, console commands or IndexedSearch parsers would generally qualify to be displayed in the configuration module. But this would lead to an unusable list. That's why I suggest to stop adding more of those providers by Core for now. -
Nikita Hovratov commented on patch set 1 04/27/22, 17:04
Reply
I think we should find a way to better categorize the configuration overview. Adding more and more to this single select will, as you said, eventually blow up. But the idea to show more registries/services is not bad per se, so do I believe. Adding custom providers should only be necessary for custom services imo. -
Josef Glatz commented on patch set 1 04/28/22, 12:41
Reply
To have such information in place is super cool. It helps the integrator and developer to have a good real overview. As this module is only aimed to admins it's subjectively no problem to have a huge list of options. Having the Module categorised would be very handy but an additional task. -
Oli Bartsch commented on patch set 1 04/28/22, 13:10
Reply
I can't really follow the argumentation regarding admins. Why should it be fine to add huge list for them? As an admin, I very often need to check the important configurations (e.g. TCA). Having to scroll through huge lists first, does not sound very efficient to me. -
Simon Schaufelberger commented on patch set 1 04/28/22, 21:39
See https://forge.typo3.org/issues/97480#note-3 as Gerrit doesn't allow images in comments -
Georg Ringer commented on patch set 1 04/29/22, 07:14
I find it useful to have all such information, the only issue I got - no matter if this patch id merged or not - that it is a <select> and there is so little information about the entries. to solve that we would again need some more interfaces and could build a better UI. by just having the title there are not that many options left. -
Benni Mack commented on patch set 1 05/11/22, 11:58
Reply
I suggest to bring this change in and then "clusterize" the Configuration View (using cards instead of the menu dropdown on the top?) -
Simon Schaufelberger commented on patch set 1 V +1 CR +1 05/11/22, 13:14
works as expected -
Simon Schaufelberger commented on patch set 1 05/11/22, 13:19
One question: Why is 'default' not showing up? -
Oliver Klee commented on patch set 1 05/11/22, 13:45
ExpressionLanguageProvider.php:25Please add a short description for the class explaining its purpose or how to use it.ExpressionLanguageProvider.php:27Please add a PHPDoc type annotation for the return array providing more details. This helps both static code analysis as well as human readers/developers, and it will be one less spot to fix when we bump the PHPStan level up so that array details are required. -
Oli Bartsch commented on patch set 1 05/12/22, 20:43
ExpressionLanguageProvider.php:25ReplyThis class is not intended to be used / instantiated directly - could also be declared final. IMO the class name, in combination with namespace and context, completely describes the purpose: Configuration provider for expression language providers. I don't know what additional information could be added here, which does not just duplicate the obvious. Do you have any suggestion? -
Simon Schaufelberger rebased onto patch set 2 06/06/22, 18:36
-
core-ci voted on patch set 2 V -1 06/06/22, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27736
-
Simon Schaufelberger uploaded patch set 3 06/06/22, 19:02
-
Oliver Klee commented on patch set 3 06/06/22, 19:08
ExpressionLanguageProvider.php:25ReplyDone -
Simon Schaufelberger uploaded patch set 4 06/06/22, 19:09
-
core-ci voted on patch set 3 V +1 06/06/22, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27740
-
Simon Schaufelberger commented on patch set 3 06/06/22, 19:10
ExpressionLanguageProvider.php:25ReplyDoneExpressionLanguageProvider.php:27ReplyIs this enough? I don't know how deep I should nest the array. -
core-ci voted on patch set 4 V +1 06/06/22, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27741
-
Oliver Klee commented on patch set 4 06/07/22, 09:41
ExpressionLanguageProvider.php:27ReplyThanks, I think this is good as a starting point. We can refine the array type annotations in later changes in bulk. -
Chris Müller commented on patch set 4 06/07/22, 16:12
Please add the new configuration also to the extensions' documentation: https://docs.typo3.org/c/typo3/cms-lowlevel/main/en-us/BackendModules/Configuration.html (like Backend Toolbar Items) -
Simon Schaufelberger uploaded patch set 5 06/08/22, 16:37
-
Simon Schaufelberger commented on patch set 5 06/08/22, 16:37
Reply
done -
core-ci voted on patch set 5 V +1 06/08/22, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27843
-
Simon Schaufelberger uploaded patch set 6 06/08/22, 16:56
-
Simon Schaufelberger commented on patch set 6 06/08/22, 17:00
Reply
Done -
core-ci voted on patch set 6 V +1 06/08/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27844
-
Oliver Klee updated the commit message in patch set 7 06/09/22, 07:49
-
Oliver Klee updated the commit message in patch set 8 06/09/22, 07:50
-
core-ci voted on patch set 8 V +1 06/09/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27860
-
core-ci voted on patch set 7 V -1 06/09/22, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27859
-
Oliver Klee wrote 06/10/22, 21:41
Removed cc Oliver Klee. -
Chris Müller uploaded patch set 9 06/11/22, 08:14
-
core-ci voted on patch set 9 V +1 06/11/22, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27966
-
Chris Müller voted on patch set 9 V +1 CR +1 06/11/22, 09:04
-
Oliver Klee commented on patch set 9 06/11/22, 19:23
SymfonyExpressionLanguageProvidersProvider.php:44This line is not needed anymore now that makeInstance uses generics. -
Oliver Klee commented on patch set 9 CR +1 06/11/22, 19:25
SymfonyExpressionLanguageProvidersProvider.php:44ReplyAh, actually it still is needed as long as getExpressionLanguageProviders() has no specific type annotations. -
Simon Schaufelberger voted on patch set 9 V +1 CR +1 06/11/22, 20:21
-
Stefan Bürk voted on patch set 9 V +1 CR +1 06/19/22, 01:10
-
Christian Kuhn commented on patch set 9 V +1 CR +1 06/19/22, 01:11
i agree this information is useful since the information is otherwise not rendered elsewhere: this registry comes from Configuration/ExpressionLanguage.php files. -
Stefan Bürk voted on patch set 9 V +2 CR +2 06/19/22, 01:11
-
Stefan Bürk merged patch set 10 06/19/22, 01:11