Review main Merged

74451[TASK] Raise symfony/rate-limiter:^5.4.8 and re-enable tests

Torben Hansen CR +2 V +2 Easy +9 −15 updated 04/29/22, 07:06

Commit message

symfony/rate-limiter:5.4.8 has been released, so the failing
tests commented out with #97298 can be included again.

Raised symfony/rate-limiter:^5.4.8 to ensure that broken
version is not used.

Used commands:

> composer req "symfony/rate-limiter":"^5.4.8"
> composer req "symfony/rate-limiter":"^5.4.8" \
    -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1725

  1. Torben Hansen uploaded patch set 1 04/28/22, 06:21

  2. core-ci voted on patch set 1 V -1 04/28/22, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26548

  3. Torben Hansen updated the commit message in patch set 2 04/28/22, 07:33

  4. core-ci voted on patch set 1 V +1 04/28/22, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26548

  5. core-ci voted on patch set 2 V +1 04/28/22, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26549

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/28/22, 11:52

  7. Simon Schaufelberger commented on patch set 2 V -1 CR 0 04/28/22, 11:54

    I guess this fails with "lowest" composer mode, so the minimal version needs to be raised as well, or?
  8. Stefan Bürk commented on patch set 2 04/28/22, 16:29

    Reply

    Yes, but the the raise can be done in this patch along with reactivating the tests. Thats fine. But the raise *must* be done, otherwise nightly tests with composerInstallMin will fail. And note the used commands for it. (not only route composer.json, but also the component composer.json where rate limiter is required). Example can be seen here (for another component): https://review.typo3.org/c/Packages/TYPO3.CMS/+/73740
    Add a "Related: #97298" after te Resolves line.
  9. Stefan Bürk uploaded patch set 3 04/28/22, 20:46

  10. Stefan Bürk updated the commit message in patch set 4 04/28/22, 20:48

  11. Stefan Bürk commented on patch set 4 04/28/22, 20:48

    Reply

    Done

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 04/28/22, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26619

  13. core-ci voted on patch set 4 V +1 04/28/22, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26620

  14. core-ci voted on patch set 4 V -1 04/28/22, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26621

  15. Stefan Bürk commented on patch set 4 04/28/22, 21:13

    https://git.typo3.org/typo3/CI/cms/-/pipelines/26621 ^ nightly test - failed, 'coz tried to change something on cloud scalling runners which failed. So failure should be ignored.
  16. Stefan Bürk commented on patch set 4 04/28/22, 21:15

    New nightly pipeline (for min/max check ): https://git.typo3.org/typo3/CI/cms/-/pipelines/26622
  17. core-ci voted on patch set 4 V +1 04/28/22, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26622

  18. Stefan Bürk voted on patch set 4 V +1 CR +1 04/28/22, 21:42

  19. Stefan Bürk updated the commit message in patch set 5 04/28/22, 21:43

  20. Stefan Bürk voted on patch set 5 V +1 CR +1 04/28/22, 21:44

  21. Simon Schaufelberger voted on patch set 5 V +1 CR +1 04/28/22, 21:45

  22. core-ci voted on patch set 5 V +1 04/28/22, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26625

  23. Oliver Klee voted on patch set 5 V +1 CR +1 04/28/22, 22:23

  24. Georg Ringer voted on patch set 5 V +2 CR +2 04/29/22, 07:05

  25. Georg Ringer merged patch set 6 04/29/22, 07:06