74451[TASK] Raise symfony/rate-limiter:^5.4.8 and re-enable tests
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 4
Review log 1725
-
Torben Hansen uploaded patch set 1 04/28/22, 06:21
-
core-ci voted on patch set 1 V -1 04/28/22, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26548
-
Torben Hansen updated the commit message in patch set 2 04/28/22, 07:33
-
core-ci voted on patch set 1 V +1 04/28/22, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26548
-
core-ci voted on patch set 2 V +1 04/28/22, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26549
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/28/22, 11:52
-
Simon Schaufelberger commented on patch set 2 V -1 CR 0 04/28/22, 11:54
I guess this fails with "lowest" composer mode, so the minimal version needs to be raised as well, or? -
Stefan Bürk commented on patch set 2 04/28/22, 16:29
Reply
Yes, but the the raise can be done in this patch along with reactivating the tests. Thats fine. But the raise *must* be done, otherwise nightly tests with composerInstallMin will fail. And note the used commands for it. (not only route composer.json, but also the component composer.json where rate limiter is required). Example can be seen here (for another component): https://review.typo3.org/c/Packages/TYPO3.CMS/+/73740Add a "Related: #97298" after te Resolves line. -
Stefan Bürk uploaded patch set 3 04/28/22, 20:46
-
Stefan Bürk updated the commit message in patch set 4 04/28/22, 20:48
-
core-ci voted on patch set 3 V +1 04/28/22, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26619
-
core-ci voted on patch set 4 V +1 04/28/22, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26620
-
core-ci voted on patch set 4 V -1 04/28/22, 21:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26621
-
Stefan Bürk commented on patch set 4 04/28/22, 21:13
https://git.typo3.org/typo3/CI/cms/-/pipelines/26621 ^ nightly test - failed, 'coz tried to change something on cloud scalling runners which failed. So failure should be ignored. -
Stefan Bürk commented on patch set 4 04/28/22, 21:15
New nightly pipeline (for min/max check ): https://git.typo3.org/typo3/CI/cms/-/pipelines/26622 -
core-ci voted on patch set 4 V +1 04/28/22, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26622
-
Stefan Bürk voted on patch set 4 V +1 CR +1 04/28/22, 21:42
-
Stefan Bürk updated the commit message in patch set 5 04/28/22, 21:43
-
Stefan Bürk voted on patch set 5 V +1 CR +1 04/28/22, 21:44
-
Simon Schaufelberger voted on patch set 5 V +1 CR +1 04/28/22, 21:45
-
core-ci voted on patch set 5 V +1 04/28/22, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26625
-
Oliver Klee voted on patch set 5 V +1 CR +1 04/28/22, 22:23
-
Georg Ringer voted on patch set 5 V +2 CR +2 04/29/22, 07:05
-
Georg Ringer merged patch set 6 04/29/22, 07:06