Review main Merged

74478[FEATURE] Add form element selection buttons to property grid rows

Tobias Jungmann CR +2 V +2 Hard +280 −146 updated 02/06/26, 18:43

Commit message

A form element selection button has been added to the property grid editors of the finishers EmailToSender and EmailToRecipient.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Sven Liebert +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Sven Liebert +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 26

Show 6 more files

Review log 71108

Show 5283 earlier messages
  1. Tobias Jungmann uploaded patch set 1 04/28/22, 13:33

  2. core-ci voted on patch set 1 V -1 04/28/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26592

  3. Tobias Jungmann uploaded patch set 2 04/28/22, 13:52

  4. core-ci voted on patch set 2 V +1 04/28/22, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26596

  5. Tobias Jungmann marked it work in progress 06/29/22, 07:13

  6. Tobias Jungmann uploaded patch set 3 06/29/22, 14:04

  7. core-ci voted on patch set 3 V -1 06/29/22, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28491

  8. Tobias Jungmann uploaded patch set 4 06/29/22, 14:17

  9. core-ci voted on patch set 4 V -1 06/29/22, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28493

  10. Tobias Jungmann marked it ready for review 06/29/22, 14:26

  11. Tobias Jungmann updated the commit message in patch set 5 06/29/22, 14:26

  12. core-ci voted on patch set 5 V -1 06/29/22, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28494

  13. core-ci voted on patch set 4 V -1 06/29/22, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28493

  14. Tobias Jungmann uploaded patch set 6 06/29/22, 15:38

  15. core-ci voted on patch set 6 V +1 06/29/22, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28502

  16. Tobias Jungmann uploaded patch set 7 06/30/22, 10:29

  17. Tobias Jungmann updated the commit message in patch set 8 06/30/22, 10:30

  18. core-ci voted on patch set 7 V +1 06/30/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28526

  19. core-ci voted on patch set 8 V +1 06/30/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28527

  20. waldhacker uploaded patch set 9 06/30/22, 10:53

  21. core-ci voted on patch set 9 V +1 06/30/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28528

  22. Tobias Jungmann updated the commit message in patch set 10 06/30/22, 11:41

  23. core-ci voted on patch set 10 V +1 06/30/22, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28529

  24. Elias Häußler commented on patch set 10 CR -1 07/01/22, 06:15

    This change needs a Feature RST
  25. Tobias Jungmann marked it work in progress 07/01/22, 08:03

  26. Tobias Jungmann uploaded patch set 11 07/01/22, 08:56

  27. Tobias Jungmann marked it ready for review 07/01/22, 08:56

  28. core-ci voted on patch set 11 V +1 07/01/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28553

  29. Björn Jacob uploaded patch set 12 07/01/22, 09:41

  30. Björn Jacob voted on patch set 12 V +1 CR +1 07/01/22, 09:47

  31. core-ci voted on patch set 12 V +1 07/01/22, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28559

  32. waldhacker commented on patch set 12 CR -1 07/02/22, 21:09

    Form.yaml:97

    These and the following new options should be included in the documentation

    inspector-component.js:2110

    The new 3rd parameter (propertyDataKey) is missing.
  33. Björn Jacob voted on patch set 12 V 0 CR 0 07/04/22, 12:41

  34. Tobias Jungmann uploaded patch set 13 07/04/22, 13:03

  35. core-ci voted on patch set 13 V -1 07/04/22, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28629

  36. core-ci commented on patch set 13 07/04/22, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28629

  37. core-ci voted on patch set 13 V +1 07/04/22, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28629

  38. Tobias Jungmann commented on patch set 13 08/16/22, 09:17

    inspector-component.js:2110 Reply

    Done
  39. Chris Müller uploaded patch set 14 10/21/22, 09:53

  40. core-ci voted on patch set 14 V +1 10/21/22, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32576

  41. Benni Mack uploaded patch set 15 V +1 07/06/23, 16:55

  42. core-ci voted on patch set 15 V +1 07/06/23, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43776

  43. Benni Mack wrote 03/28/25, 09:47

    Topic set to form
  44. Elias Häußler wrote 04/18/25, 09:39

    Removed reviewer Elias Häußler.
  45. Josua Vogel uploaded patch set 16 V +1 07/08/25, 07:06

  46. core-ci voted on patch set 16 V -1 07/08/25, 07:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81460

  47. Josua Vogel uploaded patch set 17 V -1 07/08/25, 07:19

  48. core-ci voted on patch set 17 V +1 07/08/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81461

  49. Simon Schaufelberger commented on patch set 17 07/08/25, 07:53

    form-element-selector.ts:57

    whitespace at eol

    inspector-component.ts:2221

    what exactly is this formular doing? why × 42?
  50. Josua Vogel uploaded patch set 18 V +1 07/08/25, 08:23

  51. Josua Vogel commented on patch set 18 07/08/25, 08:26

    form-element-selector.ts:57 Reply

    Deleted

    inspector-component.ts:2221 Reply

    well, that´s copy&paste from other parts of the form inspector. I think 42 is just a reference of the form autor to "The Hitchhiker's Guide to the Galaxy" 😄 I removed it - found a solution were no helper id is needed.
  52. core-ci voted on patch set 18 V +1 07/08/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81471

  53. Josua Vogel uploaded patch set 19 V +1 07/08/25, 08:44

  54. core-ci voted on patch set 19 V +1 07/08/25, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81475

  55. Josua Vogel commented on patch set 19 07/08/25, 20:05

    inspector-component.ts:2221 Reply

    Done
  56. Josua Vogel updated the commit message in patch set 20 V +1 07/25/25, 06:37

  57. core-ci voted on patch set 20 V +1 07/25/25, 06:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82302

  58. Simon Schaufelberger voted on patch set 20 CR +1 07/25/25, 08:51

  59. Josua Vogel updated the commit message in patch set 21 CR +1 V +1 07/25/25, 14:48

  60. core-ci voted on patch set 21 V +1 07/25/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82326

  61. Josua Vogel voted on patch set 21 V +1 08/15/25, 05:42

  62. Josua Vogel uploaded patch set 22 V +1 09/02/25, 18:25

  63. core-ci voted on patch set 22 V +1 09/02/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84273

  64. Josua Vogel uploaded patch set 23 V +1 09/03/25, 09:26

  65. Josua Vogel commented on patch set 23 09/03/25, 09:26

    Form.yaml:97 Reply

    Done
  66. core-ci voted on patch set 23 V +1 09/03/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84312

  67. Josua Vogel voted on patch set 23 CR +1 V +1 09/04/25, 08:35

  68. Josua Vogel uploaded patch set 24 CR +1 V +1 10/23/25, 06:34

  69. core-ci voted on patch set 24 V +1 10/23/25, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87378

  70. Josua Vogel voted on patch set 24 CR +1 V +1 10/23/25, 06:59

  71. Josua Vogel uploaded patch set 25 CR +1 V +1 11/25/25, 15:53

  72. Josua Vogel voted on patch set 25 CR +1 V +1 11/25/25, 15:53

  73. core-ci voted on patch set 25 V +1 11/25/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90964

  74. Josua Vogel uploaded patch set 26 CR +1 V +1 11/26/25, 11:01

  75. Josua Vogel voted on patch set 26 CR +1 V +1 11/26/25, 11:01

  76. core-ci voted on patch set 26 V +1 11/26/25, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91013

  77. Sven Liebert commented on patch set 26 CR +1 V +1 11/26/25, 11:21

    Form.yaml:101

    Would like to rename that here to "FormElementSelectionButton" but that would be breaking, so let's not do it now.
  78. Josua Vogel uploaded patch set 27 CR +1 V +1 01/17/26, 11:42

  79. core-ci voted on patch set 27 V +1 01/17/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93676

  80. Sven Liebert voted on patch set 27 CR +1 V +1 01/17/26, 17:07

  81. Simon Schaufelberger voted on patch set 27 CR +1 V +1 01/17/26, 17:17

  82. Josua Vogel uploaded patch set 28 CR +1 V +1 01/18/26, 15:15

  83. core-ci voted on patch set 28 V +1 01/18/26, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93721

  1. Simon Schaufelberger voted on patch set 28 CR +1 V +1 01/18/26, 16:29

  2. Simon Schaufelberger commented on patch set 28 CR 0 V 0 01/18/26, 16:33

    PropertyGridEditor.fluid.html:11

    unrelated changes
  3. Josua Vogel uploaded patch set 29 V +1 01/18/26, 16:41

  4. Josua Vogel commented on patch set 29 01/18/26, 16:42

    PropertyGridEditor.fluid.html:11 Reply

    Done
  5. Simon Schaufelberger voted on patch set 29 CR +1 V +1 01/18/26, 16:44

  6. core-ci voted on patch set 29 V +1 01/18/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93722

  7. Sven Liebert voted on patch set 29 CR +1 V +1 01/18/26, 17:46

  8. Josua Vogel commented on patch set 30 CR +1 V +1 01/19/26, 14:44

    Published edit on patch set 29.
  9. Josua Vogel commented on patch set 31 01/19/26, 14:49

    Published edit on patch set 30.
  10. core-ci voted on patch set 30 V +1 01/19/26, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93780

  11. core-ci voted on patch set 31 V +1 01/19/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93781

  12. Josua Vogel updated the commit message in patch set 32 V +1 01/19/26, 15:13

  13. core-ci voted on patch set 32 V +1 01/19/26, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93782

  14. Sven Liebert voted on patch set 32 CR +1 V +1 01/19/26, 15:35

  15. Josua Vogel uploaded patch set 33 CR +1 V +1 01/20/26, 13:55

  16. Josua Vogel voted on patch set 33 CR +1 V +1 01/20/26, 13:55

  17. core-ci voted on patch set 33 V +1 01/20/26, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93867

  18. Sven Liebert voted on patch set 33 CR +1 V +1 01/21/26, 14:22

  19. Josua Vogel uploaded patch set 34 CR +1 V +1 01/26/26, 07:30

  20. core-ci voted on patch set 34 V +1 01/26/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94338

  21. Sven Liebert voted on patch set 34 CR +1 V +1 01/26/26, 08:30

  22. Guido Schmechel voted on patch set 34 CR +1 V +1 01/26/26, 10:12

  23. Simon Schaufelberger voted on patch set 34 CR +1 V +1 01/30/26, 21:04

  24. Georg Ringer voted on patch set 34 CR +2 V +2 02/06/26, 18:43

  25. Georg Ringer merged patch set 35 02/06/26, 18:43