Review main Abandoned

74498[WIP][BUGFIX] Consider all RTE YAML configuration directives

Oliver Hader CR 0 V 0 Normal +53 −9 updated 10/15/24, 10:10

Commit message

Due to missing internal handling of provided RTE configuration,
configuration directives (`removeTags`, `allowedAttribs`) have not
been considered.

The security aspects of this scenario have been mitigated already
by introducing `typo3/html-sanitizer` in TYPO3-CORE-SA-2021-013,
see https://typo3.org/security/advisory/typo3-core-sa-2021-013

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 69

  1. Oliver Hader uploaded patch set 1 05/02/22, 10:54

  2. core-ci voted on patch set 1 V -1 05/02/22, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26722

  3. Oliver Hader commented on patch set 2 05/02/22, 12:16

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 05/02/22, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26726

  5. Oliver Hader marked it work in progress 05/03/22, 11:36

  6. Oliver Hader updated the commit message in patch set 3 08/25/22, 08:25

  7. core-ci voted on patch set 3 V -1 08/25/22, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30436

  8. Garvin Hicking abandoned the change 10/15/24, 10:10

    Abandoned due to implementation of #105254 and #86215
  9. Garvin Hicking commented on patch set 3 10/15/24, 10:10

    (Hope it's okay for you to abandon this due to the mentioned implementations. Feel free to contact me if you feel otherwise :D )