Review main Merged Breaking

74516[!!!][FEATURE] Introduce PSR-14 events in TSFE page resolving

Benni Mack CR +2 V +2 Hard +365 −89 updated 06/07/22, 21:14

Commit message

This change introduces three new PSR-14 Events in favor
of the following hooks:

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['determineId-PreProcessing']

replaced by "BeforePageIsResolvedEvent"

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['fetchPageId-PostProcessing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['settingLanguage_preProcess']

replaced by "AfterPageWithRootLineIsResolvedEvent"

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['determineId-PostProc']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['settingLanguage_postProcess']

replaced by "AfterPageAndLanguageIsResolvedEvent"

Due to the restructuring of TSFE in the past versions, it became
obvious that several hooks are called right after each other,
making them superfluous. For this reason, they have been unified.

The new PSR-14 Events are more powerful as they also contain the
current request.

In addition TSFE->determineId() can now intercept the process
by properly returning a Response object.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8