Review main Merged

74519[TASK] Simplify DataHandler internals code

Benni Mack CR +2 V +2 Normal +23 −35 updated 05/20/22, 12:22

Commit message

This change reduces specialities within DataHandler:

* DataHandler->username is not used, and can be removed.
* Initial check in workspaceCannotEditOfflineVersion() can
  be moved to the caller class, using more useful log entries.
* recordInfo() now fetches the full record from the DB which
  could then be cached separately during runtime.
* Some internal methods are marked as protected, as they
  are trivial to re-implement and currently only used by
  DataHandler anyways.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2