Review main Merged

74524[TASK] Replace deprecated doctrine/dbal 'getSchemaManager()'

Stefan Bürk CR +2 V +2 Easy +7 −9 updated 05/06/22, 13:18

Commit message

'doctrine/dbal' 3.x deprecated the 'getSchemaManager()'
method in favour of the 'createSchemaManager()' method
on connections. This has been aligned in core with the
doctrine/dbal raise in #96287. However, two occurances
with corresponding todo comments has been overseen.

This patch replace the calls and solves the comments of
the left-overs. Additionally, unrelated wrapper method in
ext:install database checks has aligned to the same name
to avoid confusion when looking for the deprecated method.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2