Review main Abandoned

74533[POC][TASK] Extract INTincScript concept from TSFE

Benni Mack CR 0 V 0 Hard +407 −142 updated 09/12/24, 11:06

Commit message

This change aims to remove all "INTincScript" functionality
out of TypoScript.

"INTincScript" - or as we call it "uncacheables" work as follows:

* Whenever a "script" (COA_INT, postUserFuncInt, USER_INT)
  defines that it should not be cached, then it just returns a
  string <!--INT_SCRIPT.123yxz--> which is put in the content
  string as a placeholder.
  It also stores the rendering instructions in $TSFE->config[INTincScript][123xyz]
  which is then put in cache.
  Various checks ("TSFE->isINTincScript") then check the array
  if content should be generated after the content is loaded or put
  in the pages cache
* When the INTincScripts are executed, TSFE loops through the
  content and explodes the content into various parts, defined by "<!--INT_SCRIPT."
  and then executes the script based on the instructions given
  in $TSFE->config[INTincScript][123xyz] effectively replaces the
  marker.
* When storing data in cache, certain states such as PageRenderer
  and AssetCollector, or additionalHeaderData and additionalFooterData
  are stored as well.

This change now moves this logic into a separate ContentManager
and defers the execution into separate Executors, this then allows
to
a) programatically execute a specific "non-cacheable" separately
b) extend the "non-cacheable" technology to become more flexible

Review

  • Code review CR 0
  • Verified V 0

Files 10

Review log 1017

  1. Benni Mack uploaded patch set 1 05/06/22, 12:57

  2. core-ci voted on patch set 1 V -1 05/06/22, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26912

  3. Benni Mack uploaded patch set 2 05/06/22, 14:33

  4. core-ci voted on patch set 2 V -1 05/06/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26922

  5. Benni Mack uploaded patch set 3 08/08/22, 12:38

  6. core-ci voted on patch set 3 V -1 08/08/22, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29953

  7. Susi Moog commented on patch set 3 09/14/22, 13:08

    ContentObjectArrayInternalContentObject.php:40 Unresolved

    not sure if combining "add" and "getHash" is nice understanding/ code-flow wise. I'd probably split both, to potentially have the option to add stuff in a different place than where the hash/placeholder is needed/rendered (not in the COA case, but might be helpful for future executor types) [[let's have a call and talk just didn't want to forget this]]
  8. Benni Mack uploaded patch set 4 10/16/22, 20:38

  9. core-ci voted on patch set 4 V -1 10/16/22, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32372

  10. Benni Mack uploaded patch set 5 11/16/22, 12:41

  11. core-ci voted on patch set 5 V -1 11/16/22, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33824

  12. Benni Mack uploaded patch set 6 V -1 12/20/22, 22:18

  13. core-ci voted on patch set 6 V -1 12/20/22, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35251

  14. Benni Mack uploaded patch set 7 V -1 03/16/23, 22:37

  15. core-ci voted on patch set 7 V -1 03/16/23, 23:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39085

  16. Benni Mack marked it work in progress 03/24/23, 11:43

  17. Benni Mack abandoned the change 09/12/24, 11:06

    wont do