Review 11.5 Merged

74546[BUGFIX] Correct type annotation of GU::callUserFunction()

Stefan Bürk CR +2 V +2 Easy +3 −17 updated 05/07/22, 12:44

Commit message

The argument `$funcName` is now annotated as `non-empty-string|\Closure`
to reflect the actual allowed input types. Additionally corresponding
test in `GeneralUtilityTest.php` is also annotated properly.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Stefan Bürk uploaded patch set 1 05/07/22, 12:34

  2. Oliver Klee voted on patch set 1 CR +1 05/07/22, 12:39

  3. core-ci voted on patch set 1 V +1 05/07/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26956

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 05/07/22, 12:44

  5. Stefan Bürk merged patch set 2 05/07/22, 12:44