74582[FEATURE] Provide default queue for notifications
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php3+16 −0
- typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php+3 −0
- typo3/sysext/core/Classes/Messaging/FlashMessageService.php+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97595-ProvideDefaultQueueForNotifications.rstnew+46 −0
Review log 2633
Show 48 earlier messages
-
Andreas Kienast uploaded patch set 1 05/09/22, 18:35
-
Andreas Kienast updated the commit message in patch set 2 05/09/22, 18:36
-
Andreas Kienast uploaded patch set 3 05/09/22, 18:45
-
core-ci voted on patch set 2 V -1 05/09/22, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27045
-
core-ci voted on patch set 1 V -1 05/09/22, 18:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27044
-
core-ci voted on patch set 3 V -1 05/09/22, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27046
-
Andreas Kienast rebased onto patch set 4 05/09/22, 18:54
-
core-ci voted on patch set 1 V -1 05/09/22, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27044
-
core-ci voted on patch set 4 V -1 05/09/22, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27047
-
Andreas Kienast rebased onto patch set 5 05/09/22, 20:19
-
core-ci voted on patch set 5 V +1 05/09/22, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27054
-
Christian Kuhn commented on patch set 5 05/09/22, 21:17
Hmm. I'm not convinced here at the moment. I understood that flash messages are something rendered when some action took place server-side, when a form has been submitted. they are displayed in the default module below the title. Notifications are client things triggered after ajax calls. Your patch creates a bridge between the two, blurring the already not-easy distinction. What are legit use cases to render these things directly php-side and not doing them js-side if needed? -
Oli Bartsch commented on patch set 5 05/09/22, 21:38
ModuleTemplate.php:465What do you think of doing this in BackendController instead? This might allow more use cases for components, not using ModuleTemplate. -
Andreas Kienast commented on patch set 5 05/10/22, 03:50
Reply
I have another patch open to demonstrate this, where a notification is rendered when a record is saved via EditDocumentController. I decided to use a notification in that case, because it's not an important information that must stay on top of the whatever loaded module (think at "save + close") forever, as notifications disappear after a few seconds.ModuleTemplate.php:465ReplyAFAICS this wouldn't help. To my understanding, BackendController is used for the "outer frame" only, that is rendered only once. -
Andreas Kienast commented on patch set 5 05/15/22, 15:18
ping for feedback -
Oli Bartsch commented on patch set 5 V +1 CR +1 05/17/22, 17:04
ModuleTemplate.php:465ReplyAck -
Benni Mack voted on patch set 5 V +1 CR +1 06/20/22, 13:22
-
Oli Bartsch rebased onto patch set 6 06/21/22, 09:12
-
core-ci voted on patch set 6 V +1 06/21/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28295
-
Simon Schaufelberger commented on patch set 6 06/21/22, 09:27
How can I test this? In the Admin log it still shows a normal flash message and no javascript based flashmessage which I would expect after this change. -
Oli Bartsch voted on patch set 6 V +1 CR +1 06/21/22, 09:27
-
Simon Schaufelberger commented on patch set 6 V -1 06/21/22, 09:29
Reply
. -
Andreas Kienast commented on patch set 6 06/21/22, 09:30
Reply
This patch doesn't change any existing flash messages, I don't know where this expectation comes from. You may test this in combination with https://review.typo3.org/c/Packages/TYPO3.CMS/+/74196. -
Andreas Kienast commented on patch set 6 06/21/22, 09:31
Simon, giving a Verified -1 is pretty harsh, isn't it? -
Simon Schaufelberger commented on patch set 6 06/21/22, 09:46
Reply
This is the commit message: "...that takes the flash message and renders it as a notification on the top-right edge of the backend." And now I would expect that existing flash message appear as notifications instead, or how can I verify the patch that it works? -
Simon Schaufelberger commented on patch set 6 06/21/22, 09:47
Reply
Since I can't verify what is written in the commit message, I give -1 -
Andreas Kienast commented on patch set 6 06/21/22, 09:50
Reply
Sorry, but giving a Verified -1 on a patch you don't know how to test (as you wrote) doesn't make sense. I already answered that your expectation of this patch is wrong and gave a hint how to test it. -
Oli Bartsch commented on patch set 6 06/21/22, 09:52
Reply
Please note that "Verified -1" is labeled with "Fails", not with "Can't verify". -
Simon Schaufelberger commented on patch set 6 06/21/22, 09:59
Reply
So basically it just gives the possibility to use that feature in custom backend modules but the core itself doesn't make use of it yet? If that is the case, then it's ok. I would expect that existing backend modules of the core already make use of this new feature when introducing it. Please clarify this! -
Andreas Kienast commented on patch set 6 06/21/22, 10:01
Reply
Exactly, this patch provides the possibility only. IMO that's already clear in the commit message. -
Simon Schaufelberger commented on patch set 6 V +1 CR +1 06/21/22, 10:17
ok -
Oli Bartsch merged patch set 7 06/21/22, 10:25