74600[BUGFIX] Show 1st constants section if no category selected
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1417
-
Georg Ringer uploaded patch set 1 05/10/22, 15:41
-
Georg Ringer commented on patch set 1 05/10/22, 15:41
This change is ready for review. -
Oliver Klee commented on patch set 1 05/10/22, 15:46
ConstantEditorController.php:118As we know that this is a string, we could make this check even more specific (as "empty" should only be the last resort because it behaves in strange ways): if ($currentCategory !== '') { Or do we also need to take the string "0" into account? What do you think? -
Georg Ringer commented on patch set 2 05/10/22, 15:47
Published edit on patch set 1. -
Georg Ringer commented on patch set 2 05/10/22, 15:47
ConstantEditorController.php:118ReplyDone -
core-ci voted on patch set 1 V +1 05/10/22, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27098
-
core-ci voted on patch set 2 V +1 05/10/22, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27099
-
Oliver Klee voted on patch set 2 CR +1 05/10/22, 15:55
-
Stefan Bürk commented on patch set 2 CR -1 05/10/22, 16:29
ConstantEditorController.php:118ReplyThats the wrong replacement: Should be ``` if($currentCategory === '') ``` -
Oliver Klee commented on patch set 3 05/10/22, 16:36
Published edit on patch set 2. -
Oliver Klee commented on patch set 3 CR +1 05/10/22, 16:36
ConstantEditorController.php:118ReplyDone -
core-ci voted on patch set 3 V +1 05/10/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27101
-
Benni Mack voted on patch set 3 CR +1 05/11/22, 10:36
-
Stefan Bürk voted on patch set 3 V +1 CR +1 05/11/22, 10:53
-
Christian Kuhn commented on patch set 3 V +1 CR +1 05/11/22, 10:54
Hmm. This still behaves a bit weird: When having a top-level page with only an extension template added (no root), and having ext:felogin loaded, then the interface now shows a "No constants available" info box, but still constants are listed and can be edited. It seems the combination of 'editorFields' and 'constantsMenu' assignments, or the fluid template could / should be improved a bit to suppress this. However, this can be done with another patch and this patch as such does what it advertises. -
Georg Ringer voted on patch set 3 V +2 CR +2 05/11/22, 13:41
-
Georg Ringer merged patch set 4 05/11/22, 13:41