Review main Merged

74603[BUGFIX] Fix notice for browse menu with no parent page

Georg Ringer CR +2 V +2 Easy +1 −1 updated 07/07/22, 15:27

Commit message

Fix a notice if a browse menu is being generated but no parent page
is available.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Torben Hansen +1
    • crell +1
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1112

  1. Georg Ringer uploaded patch set 1 05/11/22, 12:03

  2. Georg Ringer commented on patch set 1 05/11/22, 12:03

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/11/22, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27116

  4. Oliver Klee voted on patch set 1 CR +1 05/11/22, 18:30

  5. Stefan Bürk commented on patch set 1 05/11/22, 23:46

    Would it not make sense to cover this at least with a test ?
  6. Georg Ringer commented on patch set 1 05/12/22, 04:59

    of course tests are always a good idea but I would got no idea how to start for that one
  7. crell voted on patch set 1 CR +1 05/17/22, 16:35

  8. Simon Schaufelberger commented on patch set 1 V +1 CR +1 07/07/22, 01:27

    Confirmed and works
  9. Torben Hansen voted on patch set 1 CR +1 07/07/22, 05:57

  10. Nikita Hovratov voted on patch set 1 V +1 CR +1 07/07/22, 07:12

  11. Stefan Bürk voted on patch set 1 V +2 CR +2 07/07/22, 15:27

  12. Stefan Bürk merged patch set 2 07/07/22, 15:27