Review main Merged

74604[BUGFIX] Exclude doktypes in SiteConfiguration

Jochen Roth CR +2 V +2 Easy +7 −1 updated 05/13/22, 01:10

Commit message

Currently, only SysFolders are excluded in
the SiteConfiguration overview which allows
to add a SiteConfiguration to pages where
it is superfluous.

This has been fixed by adding doktype spacer, recycler,
external link to the list of excluded doktypes in
the queryBuilder statement.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1418

  1. Jochen Roth uploaded patch set 1 05/11/22, 12:52

  2. Jochen Roth updated the commit message in patch set 2 05/11/22, 12:54

  3. core-ci voted on patch set 1 V +1 05/11/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27118

  4. core-ci voted on patch set 2 V +1 05/11/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27119

  5. Oli Bartsch commented on patch set 2 05/11/22, 20:09

    SiteConfigurationController.php:704

    Could we also adjust this comment, since pages are selected which either have the "is_siteroot" flag set or are on pid=0 and not of the excluded doktypes.
  6. Jochen Roth uploaded patch set 3 05/11/22, 22:51

  7. Jochen Roth commented on patch set 3 05/11/22, 22:51

    SiteConfigurationController.php:704 Reply

    Done
  8. core-ci voted on patch set 3 V +1 05/11/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27127

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 05/12/22, 07:29

  10. Oliver Klee voted on patch set 3 CR +1 05/12/22, 08:12

  11. Oli Bartsch commented on patch set 3 05/12/22, 11:36

    I think this change does not qualify for backport.
  12. Jochen Roth updated the commit message in patch set 4 05/12/22, 11:54

  13. Jochen Roth commented on patch set 4 05/12/22, 11:55

    Reply

    Ok, makes sense.
  14. Oli Bartsch commented on patch set 4 V +1 CR +1 05/12/22, 12:00

    Reply

    Done
  15. core-ci voted on patch set 4 V +1 05/12/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27139

  16. Oliver Klee voted on patch set 4 CR +1 05/12/22, 12:49

  17. Stefan Bürk commented on patch set 4 V +2 CR +2 05/13/22, 01:05

    Just to note: I think we should think about some tests/verification on other places too to prevent doktype changes afterwards to a invalid doctype, if a page is a siteroot with connected siteconfiguration.
  18. Stefan Bürk merged patch set 5 05/13/22, 01:10