74604[BUGFIX] Exclude doktypes in SiteConfiguration
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1418
-
Jochen Roth uploaded patch set 1 05/11/22, 12:52
-
Jochen Roth updated the commit message in patch set 2 05/11/22, 12:54
-
core-ci voted on patch set 1 V +1 05/11/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27118
-
core-ci voted on patch set 2 V +1 05/11/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27119
-
Oli Bartsch commented on patch set 2 05/11/22, 20:09
-
Jochen Roth uploaded patch set 3 05/11/22, 22:51
-
Jochen Roth commented on patch set 3 05/11/22, 22:51
SiteConfigurationController.php:704ReplyDone -
core-ci voted on patch set 3 V +1 05/11/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27127
-
Andreas Kienast voted on patch set 3 V +1 CR +1 05/12/22, 07:29
-
Oliver Klee voted on patch set 3 CR +1 05/12/22, 08:12
-
Oli Bartsch commented on patch set 3 05/12/22, 11:36
I think this change does not qualify for backport. -
Jochen Roth updated the commit message in patch set 4 05/12/22, 11:54
-
Jochen Roth commented on patch set 4 05/12/22, 11:55
Reply
Ok, makes sense. -
Oli Bartsch commented on patch set 4 V +1 CR +1 05/12/22, 12:00
Reply
Done -
core-ci voted on patch set 4 V +1 05/12/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27139
-
Oliver Klee voted on patch set 4 CR +1 05/12/22, 12:49
-
Stefan Bürk commented on patch set 4 V +2 CR +2 05/13/22, 01:05
Just to note: I think we should think about some tests/verification on other places too to prevent doktype changes afterwards to a invalid doctype, if a page is a siteroot with connected siteconfiguration. -
Stefan Bürk merged patch set 5 05/13/22, 01:10
SiteConfigurationController.php:704