Review main Merged

74605[TASK] Raise lolli42/finediff:^1.0.1

Christian Kuhn CR +2 V +2 Easy +9 −9 updated 05/11/22, 14:42

Commit message

Brings a multibyte fix when dealing with word-based
diffs, which is our default usage.

composer req lolli42/finediff:^1.0.1

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1113

  1. Christian Kuhn uploaded patch set 1 05/11/22, 14:18

  2. Stefan Bürk voted on patch set 1 CR +1 05/11/22, 14:23

  3. Oliver Klee voted on patch set 1 CR +1 05/11/22, 14:25

  4. core-ci voted on patch set 1 V -1 05/11/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27120

  5. Stefan Bürk commented on patch set 1 CR 0 05/11/22, 14:26

    Ahh - correct. Needs to be raised for corresponding sysext also ;) not only root composer.json
  6. Christian Kuhn uploaded patch set 2 05/11/22, 14:27

  7. Oliver Klee voted on patch set 2 CR +1 05/11/22, 14:28

  8. Christian Kuhn commented on patch set 2 05/11/22, 14:28

    sorry, missed the ext:core raise ... added now.
  9. core-ci voted on patch set 2 V +1 05/11/22, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27121

  10. Oliver Klee voted on patch set 2 V +1 05/11/22, 14:38

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 05/11/22, 14:40

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 05/11/22, 14:42

  13. Christian Kuhn merged patch set 3 05/11/22, 14:42