Review 11.5 Merged

74621[BUGFIX] Stop mocking classes that do not exist

Stefan Bürk CR +2 V +2 Easy +5 −28 updated 05/16/22, 16:13

Commit message

This is only possible with PHPUnit, not with Prophecy, and it is bad
practice as there is no way to do type analysis on classes that do
not exist.

Also avoid using mocks where an `stdClass` instance does just fine.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3