74632[BUGFIX] Apply empty values in language-overlay
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1518
-
André Buchmann uploaded patch set 1 05/12/22, 14:08
-
core-ci voted on patch set 1 V +1 05/12/22, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27144
-
Oliver Klee voted on patch set 1 CR +1 05/12/22, 17:10
-
Benni Mack commented on patch set 1 CR -1 05/13/22, 11:33
This should get a test, I will provide one -
André Buchmann commented on patch set 1 05/13/22, 12:17
Reply
Thanks! -
Benni Mack uploaded patch set 2 06/07/22, 20:58
-
Benni Mack commented on patch set 2 V +1 CR +1 06/07/22, 20:59
Reply
Done -
core-ci voted on patch set 2 V +1 06/07/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27780
-
Oli Bartsch voted on patch set 2 V +1 CR +1 06/07/22, 21:06
-
Oliver Klee commented on patch set 2 CR -1 06/07/22, 21:14
PageRepositoryTest.php:694Generally, please use assertSame instead of assertEquals unless you need the not-strict comparison. (assertSame is to assertEquals what === is to == .)PageRepositoryTest.php:703This looks like a left-over debug statement. -
Benni Mack uploaded patch set 3 06/08/22, 06:32
-
Benni Mack commented on patch set 2 V +1 CR +1 06/08/22, 06:32
PageRepositoryTest.php:694ReplyDonePageRepositoryTest.php:703ReplyTHANKS! -
core-ci voted on patch set 3 V +1 06/08/22, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27790
-
Oli Bartsch voted on patch set 3 V +1 CR +1 06/08/22, 07:09
-
Oliver Klee voted on patch set 3 CR +1 06/08/22, 09:41
-
Benni Mack voted on patch set 3 V +2 CR +2 06/08/22, 11:38
-
Benni Mack merged patch set 4 06/08/22, 11:38
-
André Buchmann voted on patch set 3 V +1 CR +1 06/08/22, 11:44