Review main Merged

74634[BUGFIX] Fix type issues in Request

crell CR +2 V +2 Normal +51 −198 updated 07/07/22, 20:33

Commit message

This patch adds property and return types to the core Request class.
Parameter types cannot be added to methods from RequestInterface
as it has no typed version yet.

Doing so allows for the removal of a lot of now-unnecessary tests
as well as PHPstan baseline issues.

This patch also notes, but does not correct, the incorrect
implementation of getUri(), which this implementation permits
to return null even though that is a PSR-7 violation. Fixing
that has several knock-on effects better addressed in
future patches.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6