Review main Merged

74638[TASK] Simplify code in ConjunctionValidator

crell CR +2 V +2 Easy +4 −19 updated 05/25/22, 11:14

Commit message

The code in ConjunctionValidator can be greatly
simplified by taking advantage of the fact that
an empty result object can be merged with a future
one. That eliminates an unnecessary code path as
well as phpstan warnings.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2