Review main Abandoned

74642[WIP][TASK] Configure phpstan to not take php docblock types as certain

Stefan Bürk CR 0 V 0 Normal +11 −130 updated 05/28/22, 21:00

Commit message

Code checking argument with docblock types and no native types set
leads to false-positive issue reporting. Thus not taking docblock
types as certain will relax this situation. Adding native-types to
the argument however will detect these cases again, so superfluous
code can be removed, when it is safe.

See: https://phpstan.org/config-reference#treatphpdoctypesascertain

This patch sets the corresponding phpstan option to ensure that no
type guarding code, if it is not ensured through e.g. proper native
types and declare strict.

Used command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2