Review main Merged

74650[BUGFIX] Use plugin icon in content element preview

Torben Hansen CR +2 V +2 Normal +69 −2 updated 05/20/22, 06:47

Commit message

It is possible to register a dedicated icon for a plugin in
ExtensionUtility::registerPlugin(). This icon is used in the
plugin select field, but not for the content element preview
where always a default icon is shown.

With this change, a possible configured plugin icon is used
in content element preview, if the icon is registered using
the TYPO3 icon API.

Additionally the indexed_search plugin now uses
'mimetypes-x-content-form-search' as plugin icon.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Torben Hansen uploaded patch set 1 05/15/22, 17:36

  2. core-ci voted on patch set 1 V +1 05/15/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27232

  3. Stefan Bürk commented on patch set 1 05/16/22, 08:47

    IconFactory.php:258

    Should we not use the plugin icon as "$recordType[7]" ? At least, each adding to $recordType happens with a pre-defined value, so this one should get a (unique) one too. If $row is a plugin with a registered icon, this overrules all other definitions, if defined icon exists. (highest priority). I think, this is wanted. However, we should keep with hard-defined priorities to be expressive - instead of simply adding the plugin as current highest index value.
  4. Torben Hansen commented on patch set 1 05/16/22, 09:17

    IconFactory.php:258 Reply

    Done
  5. Torben Hansen uploaded patch set 2 05/16/22, 09:17

  6. core-ci voted on patch set 2 V -1 05/16/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27252

  7. Torben Hansen uploaded patch set 3 05/16/22, 09:51

  8. core-ci voted on patch set 3 V +1 05/16/22, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27253

  9. Benni Mack commented on patch set 3 05/16/22, 10:54

    tbh, this is a bugfix for me... no change in APIs, the 4th argument is actually working for regular CTypes but just not for plugins...
  10. Torben Hansen uploaded patch set 4 05/16/22, 11:52

  11. core-ci voted on patch set 4 V +1 05/16/22, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27254

  12. Jonas Eberle voted on patch set 4 V +1 05/16/22, 12:32

  13. Simon Schaufelberger voted on patch set 4 V +1 CR +1 05/19/22, 21:35

  14. Benni Mack commented on patch set 4 V +2 CR +2 05/20/22, 06:47

    Thanks, everyone!
  15. Benni Mack merged patch set 5 05/20/22, 06:47