74654[BUGFIX] Resolve type issues in SemaphoreLockStrategy
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
crell uploaded patch set 1 05/16/22, 20:26
-
core-ci voted on patch set 1 V -1 05/16/22, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27264
-
Stefan Bürk commented on patch set 1 05/16/22, 23:16
-
Stefan Bürk commented on patch set 1 05/16/22, 23:16
SemaphoreLockStrategy.php:40ReplyDone -
Stefan Bürk uploaded patch set 2 05/16/22, 23:16
-
core-ci voted on patch set 2 V +1 05/16/22, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27269
-
Stefan Bürk voted on patch set 2 V +1 CR +1 05/16/22, 23:25
-
Oliver Klee voted on patch set 2 CR +1 05/17/22, 08:03
-
crell commented on patch set 2 05/17/22, 14:10
SemaphoreLockStrategy.php:40ReplyOnly if the default is to use this lock strategy. If the default is some other lock system then I don't know that it's necessary. Honestly I don't think I've seen anyone actually use sysvsem in practice. shrug.gif Off topic for this patch either way though, yes. -
Oliver Klee wrote 05/18/22, 19:41
Removed reviewer Oliver Klee with the following votes: * Code-Review+1 by Oliver Klee -
Benni Mack voted on patch set 2 V +2 CR +2 05/20/22, 06:34
-
Benni Mack merged patch set 3 05/20/22, 06:34
SemaphoreLockStrategy.php:40