Review main Merged

74654[BUGFIX] Resolve type issues in SemaphoreLockStrategy

crell CR +2 V +2 Easy +2 −12 updated 05/20/22, 06:34

Commit message

ftok() doesn't return false, but -1 on error.

The $resource property may be null to indicate no lock
is active, so allow that.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. crell uploaded patch set 1 05/16/22, 20:26

  2. core-ci voted on patch set 1 V -1 05/16/22, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27264

  3. Stefan Bürk commented on patch set 1 05/16/22, 23:16

    SemaphoreLockStrategy.php:40

    Mhh .. we do not have `ext-sysvsem` as requirement, dev-requirement or even as suggestion in any composer.json - maybe another oversight for another patch ?
  4. Stefan Bürk commented on patch set 1 05/16/22, 23:16

    SemaphoreLockStrategy.php:40 Reply

    Done
  5. Stefan Bürk uploaded patch set 2 05/16/22, 23:16

  6. core-ci voted on patch set 2 V +1 05/16/22, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27269

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 05/16/22, 23:25

  8. Oliver Klee voted on patch set 2 CR +1 05/17/22, 08:03

  9. crell commented on patch set 2 05/17/22, 14:10

    SemaphoreLockStrategy.php:40 Reply

    Only if the default is to use this lock strategy. If the default is some other lock system then I don't know that it's necessary. Honestly I don't think I've seen anyone actually use sysvsem in practice. shrug.gif Off topic for this patch either way though, yes.
  10. Oliver Klee wrote 05/18/22, 19:41

    Removed reviewer Oliver Klee with the following votes: * Code-Review+1 by Oliver Klee
  11. Benni Mack voted on patch set 2 V +2 CR +2 05/20/22, 06:34

  12. Benni Mack merged patch set 3 05/20/22, 06:34