Review main Merged

74673[BUGFIX] Respect ordering in pagination of redirect module

Georg Ringer CR +2 V +2 Easy +6 −6 updated 06/04/22, 21:07

Commit message

The pagination links of the redirects module must respect a given
ordering.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 05/17/22, 09:11

  2. Georg Ringer commented on patch set 1 05/17/22, 09:11

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/17/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27278

  4. Sven Liebert voted on patch set 1 V +1 CR +1 05/17/22, 10:09

  5. Georg Ringer commented on patch set 1 05/17/22, 18:22

    to avoid adding more than 50 redirects, just change the limit in the Demand class to 2 and you are good to go with 10 ;)
  6. Oli Bartsch commented on patch set 1 05/17/22, 20:06

    Pagination.html:7

    Should be added here as well.

    Pagination.html:12

    Should be added here as well.
  7. Georg Ringer uploaded patch set 2 06/02/22, 06:34

  8. core-ci voted on patch set 2 V +1 06/02/22, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27641

  9. Stefan Bürk commented on patch set 2 V +1 CR +1 06/03/22, 17:35

    Pagination.html:7 Reply

    Done

    Pagination.html:12 Reply

    Done
  10. Nikita Hovratov voted on patch set 2 V +2 CR +2 06/04/22, 21:06

  11. Nikita Hovratov merged patch set 3 06/04/22, 21:07