TYPO3 Forger
  • Dashboard
  • Get involved
  • Reviews
    Overview Ready for review Work in progress Needs action Needs review Needs verification Needs rebase Negative votes Reviewed and verified Ready to merge
  • Issues
    Stale issues Possible duplicates By category By month
  • Sprints
    Overview Initiatives TYPO3 Core Review board
  • Tools
    Backports ReST helper
  • Help
  • Search
  • Login
Esc

Words find the open ones, a number the issue and the change with it.

  1. Reviews
  2. Change 74684
Review main Abandoned

74684[TASK] Resolve PHPStan issues around pointless else clauses

crell CR 0 V 0 Normal +19 −85 updated 06/24/22, 16:55

Open in Gerrit

Commit message

Resolves: #97657
Releases: main
Change-Id: Ied5f4ecc70ad154cd11949cc33fe08ddcaa8c5c2

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

  • Task #97657Resolve PHPStan issues around pointless elses Resolved by this change Rejected v12 Larry Garfield 05/18/22, 18:04

Files 13

  • Build/phpstan/phpstan-baseline.neon
  • typo3/sysext/backend/Classes/Search/LiveSearch/QueryParser.php
  • typo3/sysext/core/Classes/LinkHandling/LinkService.php
  • typo3/sysext/core/Classes/Localization/LanguageService.php
  • typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php
  • typo3/sysext/core/Classes/Type/File/ImageInfo.php
  • typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
  • typo3/sysext/core/Classes/TypoScript/TemplateService.php
  • typo3/sysext/core/Classes/Utility/CsvUtility.php
  • typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php
  • typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php
  • typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php
  • typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php
Owner
crell
Target releases
main
Tags
TASK
Patch sets
3
Created
05/18/22, 18:05
Change-Id
Ied5f4ecc70ad154cd11949cc33fe08ddcaa8c5c2
© 2026 TYPO3 GmbH.
  • API
  • Privacy Policy
  • Legal Notice
  • Feedback