Review main Merged

74739[BUGFIX] Take dev mode into account for package hash

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 05/25/22, 11:06

Commit message

When generating the identifier for the package artifact,
not only the hash from the composer.lock must be taken
into account, but also whether packages have been installed
in dev mode or not.

Since dev mode does not change the lock hash, it otherwise
can happen that a stale DI cache with invalid set of
packages is used, which obviously leads to fatal errors

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Gilli +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Helmut Hummel uploaded patch set 1 05/24/22, 17:44

  2. Helmut Hummel updated the commit message in patch set 2 05/24/22, 17:46

  3. core-ci voted on patch set 2 V +1 05/24/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27438

  4. Simon Gilli commented on patch set 2 V +1 CR +1 05/24/22, 17:57

    Works great, thanks!
  5. core-ci voted on patch set 1 V +1 05/24/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27437

  6. Chris Müller commented on patch set 2 05/24/22, 17:59

    PackageArtifactBuilder.php:103

    Shouldn't it $this->event instead of event to be in-line with above?
  7. Oliver Klee voted on patch set 2 CR +1 05/24/22, 18:30

  8. Helmut Hummel uploaded patch set 3 05/25/22, 07:21

  9. Helmut Hummel commented on patch set 3 05/25/22, 07:21

    PackageArtifactBuilder.php:103 Reply

    Done
  10. core-ci voted on patch set 3 V +1 05/25/22, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27443

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 05/25/22, 07:53

  12. Simon Gilli voted on patch set 3 V +1 CR +1 05/25/22, 09:14

  13. Oliver Klee voted on patch set 3 CR +1 05/25/22, 09:44

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 05/25/22, 10:34

  15. Helmut Hummel commented on patch set 3 V +2 CR +2 05/25/22, 11:06

    Thanks for the reviews!
  16. Helmut Hummel merged patch set 4 05/25/22, 11:06