74739[BUGFIX] Take dev mode into account for package hash
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Oli Bartsch +1
- Oliver Klee +1
- Simon Gilli +1
- Christian Kuhn +1
-
Verified V +2 Done
- Helmut Hummel +2
- Oli Bartsch +1
- Simon Gilli +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1316
-
Helmut Hummel uploaded patch set 1 05/24/22, 17:44
-
Helmut Hummel updated the commit message in patch set 2 05/24/22, 17:46
-
core-ci voted on patch set 2 V +1 05/24/22, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27438
-
Simon Gilli commented on patch set 2 V +1 CR +1 05/24/22, 17:57
Works great, thanks! -
core-ci voted on patch set 1 V +1 05/24/22, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27437
-
Chris Müller commented on patch set 2 05/24/22, 17:59
PackageArtifactBuilder.php:103Shouldn't it $this->event instead of event to be in-line with above? -
Oliver Klee voted on patch set 2 CR +1 05/24/22, 18:30
-
Helmut Hummel uploaded patch set 3 05/25/22, 07:21
-
Helmut Hummel commented on patch set 3 05/25/22, 07:21
PackageArtifactBuilder.php:103ReplyDone -
core-ci voted on patch set 3 V +1 05/25/22, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27443
-
Christian Kuhn voted on patch set 3 V +1 CR +1 05/25/22, 07:53
-
Simon Gilli voted on patch set 3 V +1 CR +1 05/25/22, 09:14
-
Oliver Klee voted on patch set 3 CR +1 05/25/22, 09:44
-
Oli Bartsch voted on patch set 3 V +1 CR +1 05/25/22, 10:34
-
Helmut Hummel commented on patch set 3 V +2 CR +2 05/25/22, 11:06
Thanks for the reviews! -
Helmut Hummel merged patch set 4 05/25/22, 11:06