Review main Merged

74775[BUGFIX] Avoid invalid type exception in FinisherVariableProvider

Josua Vogel CR +2 V +2 Easy +1 −1 updated 06/15/22, 09:20

Commit message

Guard invalid argument type exception by using null coalescing operator
in `\TYPO3\CMS\Form\Domain\Finishers\FinisherVariableProvider`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • crell +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. Josua Vogel uploaded patch set 1 05/27/22, 14:23

  2. core-ci voted on patch set 1 V -1 05/27/22, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27494

  3. Mathias Brodala commented on patch set 1 05/27/22, 14:41

    FinisherVariableProvider.php:103

    We could use "... ?? []" here IMO.
  4. Josua Vogel uploaded patch set 2 05/27/22, 14:51

  5. core-ci voted on patch set 2 V +1 05/27/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27496

  6. Stefan Bürk updated the commit message in patch set 3 05/27/22, 14:59

  7. Stefan Bürk updated the commit message in patch set 4 05/27/22, 15:00

  8. Stefan Bürk commented on patch set 4 V +1 CR +1 05/27/22, 15:01

    Thanks for thix bugfix patch, Josua.

    FinisherVariableProvider.php:103 Reply

    Done
  9. core-ci voted on patch set 3 V +1 05/27/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27497

  10. core-ci voted on patch set 4 V -1 05/27/22, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27498

  11. core-ci voted on patch set 4 V +1 05/27/22, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27498

  12. crell voted on patch set 4 CR +1 05/27/22, 16:28

  13. Oliver Klee voted on patch set 4 CR +1 05/27/22, 16:37

  14. Oli Bartsch voted on patch set 4 V +2 CR +2 06/07/22, 06:36

  15. Oli Bartsch merged patch set 5 06/07/22, 06:36

  16. Andreas Kienast commented on patch set 5 06/15/22, 09:20

    We just got an error for v9 ELTS that could've been fixed by this patch. Is there any reason why this wasn't backported to v10 as well?