Review main Merged

74820[DOCS] Make example more general to not confuse

TYPO3com CR +2 V +2 Easy +3 −2 updated 06/07/22, 08:44

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Björn Jacob +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Björn Jacob +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. TYPO3com uploaded patch set 1 06/06/22, 09:10

  2. core-ci voted on patch set 1 V +1 06/06/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27720

  3. Simon Schaufelberger commented on patch set 1 CR -1 06/06/22, 11:12

    Feature-97096-Non-namespacedArgumentsInExtbaseBackendModules.rst:39

    that path is not best practice. it should be under configuration
  4. Simon Schaufelberger commented on patch set 1 V +1 CR +1 06/07/22, 01:47

    Feature-97096-Non-namespacedArgumentsInExtbaseBackendModules.rst:39 Reply

    oh sorry, in this case it is better to use the autoloaded file.
  5. Björn Jacob voted on patch set 1 V +1 CR +1 06/07/22, 07:10

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 06/07/22, 08:44

  7. Oli Bartsch merged patch set 2 06/07/22, 08:44