74821[WIP][FEATURE] Add baseUrl argument to NormalizedUrl vh
Commit message
Review
-
Code review CR 0
-
Verified V -1
- Helmut Hummel -1
Issues 1
Files 3
Review log 4161
Show 2436 earlier messages
-
Roman Büchler uploaded patch set 1 06/06/22, 09:17
-
core-ci voted on patch set 1 V -1 06/06/22, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27721
-
Roman Büchler uploaded patch set 2 06/06/22, 09:29
-
Roman Büchler uploaded patch set 3 06/06/22, 09:32
-
core-ci voted on patch set 2 V -1 06/06/22, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27722
-
core-ci voted on patch set 3 V +1 06/06/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27723
-
Joey Bouten voted on patch set 3 CR +1 06/08/22, 12:23
-
Oliver Klee updated the commit message in patch set 4 06/09/22, 07:46
-
Oliver Klee updated the commit message in patch set 5 06/09/22, 07:46
-
Oliver Klee commented on patch set 5 06/09/22, 07:49
NormalizedUrlViewHelperTest.php:49There are two distinct test cases hidden here (as indicated by the "And" in the name). :-) Please let's split this up. (Then we also don't need the data provider anymore.) -
core-ci voted on patch set 4 V +1 06/09/22, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27857
-
core-ci voted on patch set 5 V +1 06/09/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27858
-
Benni Mack updated the commit message in patch set 6 06/09/22, 14:34
-
core-ci voted on patch set 6 V +1 06/09/22, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27892
-
Roman Büchler commented on patch set 6 06/11/22, 05:54
Thank you for the help!NormalizedUrlViewHelperTest.php:25ReplyDoneNormalizedUrlViewHelperTest.php:49ReplyDone -
Roman Büchler uploaded patch set 7 06/11/22, 05:55
-
core-ci voted on patch set 7 V +1 06/11/22, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27965
-
Oliver Klee commented on patch set 7 06/11/22, 08:00
NormalizedUrlViewHelper.php:54I don't understand the difference between the host names remote.foo and local.foo here. If they're note relevant. I propose using the recommend dummy host name example.com in all cases.NormalizedUrlViewHelper.php:83In which cases would the parse_url fail?NormalizedUrlViewHelper.php:87I'm still trying (and failing) to understand this method. Maybe we could use different local variables for the different kinds of paths to make the implicit differences explicit. What do you think?NormalizedUrlViewHelperTest.php:39If the exact host name is not relevant, I recommend using one the official dummy host names, e.g. example.com. -
Oliver Klee commented on patch set 7 06/11/22, 08:28
Roman, maybe we can chat about this or work on this together. I couldn't find you on Slack, though. Ping me on Slack if you would like to tackle this together. -
Oliver Klee uploaded patch set 8 06/11/22, 10:24
-
Oliver Klee voted on patch set 8 V +1 CR +1 06/11/22, 10:25
-
Oliver Klee commented on patch set 8 06/11/22, 10:25
NormalizedUrlViewHelper.php:54ReplyDoneNormalizedUrlViewHelper.php:83ReplyDoneNormalizedUrlViewHelper.php:87ReplyDone -
Oliver Klee commented on patch set 8 06/11/22, 10:25
NormalizedUrlViewHelperTest.php:39ReplyDone -
core-ci voted on patch set 8 V -1 06/11/22, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27970
-
Oliver Klee commented on patch set 8 V -1 CR 0 06/11/22, 10:36
Oh, this breaks some functional tests. I think we have missed some cases the method also needs to consider. -
Oliver Klee commented on patch set 8 06/11/22, 10:37
(Or we need to adapt the affected functional tests. In any case, we need to investigate the test failures.) -
Stefan Bürk commented on patch set 8 06/11/22, 17:11
NormalizedUrlViewHelper.php:80We should avoid using acient GU::getIndpEnv() here and instead use the request (e.g. $renderingContext->getRequest()->getUri()->getHost()). Functional tests has to be adopted to either provider probler global request object / setRequest in the injected rendering context. Or doing executed frontend requests which automatically inject correspondign request objects in the viehelper contexts etc. Also needed to be adjusted in related failing tests. -
Roman Büchler uploaded patch set 9 06/18/22, 11:13
-
core-ci voted on patch set 9 V -1 06/18/22, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28172
-
Roman Büchler uploaded patch set 10 06/18/22, 11:36
-
core-ci voted on patch set 10 V -1 06/18/22, 11:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28175
-
Roman Büchler commented on patch set 10 06/18/22, 11:49
Now functional tests reltaed to - Mail\FluidEmail - Authentication\PasswordReset fail. What do you think should those be adapted?NormalizedUrlViewHelper.php:80ReplyDone -
Roman Büchler uploaded patch set 11 06/19/22, 05:14
-
core-ci voted on patch set 11 V -1 06/19/22, 05:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28214
-
Roman Büchler uploaded patch set 12 06/19/22, 16:33
-
core-ci voted on patch set 12 V -1 06/19/22, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28223
-
Roman Büchler commented on patch set 12 06/19/22, 18:26
> Patch Set 12: Verified-1 > > Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28223 The failed test runs successfully through on the local environment using the following command: ``` Build/Scripts/runTests.sh -s acceptance -p 8.1 -d mariadb -i 10.3 typo3/sysext/core/Tests/Acceptance/Application/PageTree/PageTreeFilterCest.php:clearFilterReloadsPageTreeWithoutFilterApplied ``` Do you see what causes the issue? -
core-ci commented on patch set 12 06/19/22, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28223
-
core-ci voted on patch set 12 V +1 06/19/22, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28223
-
Stefan Bürk commented on patch set 12 06/19/22, 20:50
Reply
PageTreeFilterCest is "known" to be flaky - We had some tried to make it more stable, and Jochen Roth has the task to came up with a better solution for this. Without going to much into detail, it is related to jquery removal and thus not having a proper check for "ajax requests all done" equialent for now as before with jquery - thus this failing on main. But we are on it, so take my apologice for it. However, restartet the failed job pipeline until it went green. Resolving this comment for now, hope this is okay. -
Oliver Klee commented on patch set 12 CR -1 06/20/22, 19:12
-1 until after our call on Thursday :-) (also also due to the added PHPStan warning). -
Roman Büchler uploaded patch set 13 06/23/22, 14:46
-
core-ci voted on patch set 13 V -1 06/23/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28355
-
Roman Büchler uploaded patch set 14 06/23/22, 15:25
-
core-ci voted on patch set 14 V +1 06/23/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28356
-
Benni Mack commented on patch set 14 04/14/23, 10:03
any update here? As v10.4 will soon be out of our support, we should adapt or abandon this change. -
Benni Mack updated the commit message in patch set 15
V +105/03/23, 09:45 -
Roman Büchler uploaded patch set 16 05/31/23, 11:39
-
core-ci voted on patch set 16 V -1 05/31/23, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42111
-
Roman Büchler uploaded patch set 17
V -105/31/23, 16:05 -
core-ci voted on patch set 17 V -1 05/31/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42118
-
Stefan Bürk commented on patch set 17 05/31/23, 16:46
NormalizedUrlViewHelperTest.php:44UnresolvedThis should be not needed or ?NormalizedUrlViewHelperTest.php:69UnresolvedDataProvider must be staticNormalizedUrlViewHelperTest.php:93UnresolvedDataProvider must be staticNormalizedUrlViewHelperTest.php:115UnresolvedDataProvider must be static -
Roman Büchler uploaded patch set 18
V -105/31/23, 16:56 -
Roman Büchler uploaded patch set 19 05/31/23, 17:02
-
core-ci voted on patch set 18 V -1 05/31/23, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42119
-
core-ci voted on patch set 19 V +1 05/31/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42120
-
Benni Mack updated the commit message in patch set 20
V +110/18/24, 14:07 -
Helmut Hummel commented on patch set 20 V -1 10/02/25, 09:20
This will be fixed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/90675 in a global and consistent way. the question is, whether a fix is needed for current typo3 versions -
Benni Mack wrote 04/21/26, 14:57
Removed cc Benni Mack. -
Benni Mack marked it work in progress 04/21/26, 14:57
-
Benni Mack abandoned the change 11/10/26, 11:26
NormalizedUrlViewHelperTest.php:25