Review main Merged

74885[BUGFIX] Avoid parameter collision in IndexedSearch

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 06/13/22, 22:46

Commit message

The action to delete an indexed item in the IndexedSearch
backend module used the "id" parameter to pass the indexed
item id to the method. The controller is based on extbase and
previously, those parameters were prefixed with the plugin
namespace. However, with #97096 the parameters in extbase
backend modules are no longer prefix by default, which therefore
lead to a collision. The "id" parameter should always represent
the currently selected page, underlying code performs access
checks on this value.

This is now resolved by using a dedicated parameter, which
is not already "reserved" by underlying functionality.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2