74910[BUGFIX] Properly apply system maintainer role to backend admins
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Thomas Hohn +1
- Markus Klein +1
- Andreas Kienast +1
- Xavier Perseguers +1
- Rudy Gnodde +1
-
Verified V +2 Done
- Oliver Hader +2
- Thomas Hohn +1
- Andreas Kienast +1
- Xavier Perseguers +1
- Rudy Gnodde +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1314
-
Oliver Hader uploaded patch set 1 06/14/22, 11:43
-
core-ci voted on patch set 1 V +1 06/14/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28072
-
Thomas Hohn voted on patch set 1 V +1 CR +1 06/14/22, 11:55
-
Rudy Gnodde voted on patch set 1 V +1 CR +1 06/14/22, 11:55
-
Markus Klein voted on patch set 1 CR +1 06/14/22, 11:56
-
Andreas Kienast voted on patch set 1 V +1 CR +1 06/14/22, 14:38
-
Xavier Perseguers commented on patch set 1 V +1 CR +1 06/14/22, 14:41
Tested with v10.4.29, both in dev and production modes. -
Jonas Eberle commented on patch set 1 06/14/22, 15:29
SessionService.php:279Maybe add ( ) here or is that too obvious and only I have to look twice? -
Oliver Hader commented on patch set 1 06/14/22, 19:49
SessionService.php:279Reply"Look twice" :) To me it's like "1 + 2 * 3" -
Simon Schaufelberger commented on patch set 1 06/15/22, 00:10
I give a verbal -1 to not block anything but improve readability.SessionService.php:279ReplyMy Phpstorm with Plugin https://plugins.jetbrains.com/plugin/7622-php-inspections-ea-extended- also complains. It's correct, but brackets would definitely help! PS: I highly recommend installing this plugin! -
Oliver Hader commented on patch set 1 06/15/22, 05:58
SessionService.php:279Replyhttps://plugins.jetbrains.com/plugin/7622-php-inspections-ea-extended-/reviews > Anton 05.05.2022 > Thanks for the work you've done! The plugin is "must have" to junior, "may have" for middle and "must ignore" for senior developers. Many of inspections enabled by default are triggered for wrong reasons: these "smart" inspections find "errors" base on regexp matches instead of code analysis. → I'm going to ignore that cosmetic change for the time being. Please, go ahead and add parenthesis anywhere you'd like in separate change-sets... -
Markus Klein commented on patch set 1 06/15/22, 07:19
SessionService.php:279ReplySorry to step in here, but I'm 100% with Olly here! -
Oliver Hader voted on patch set 1 V +2 CR +2 06/15/22, 07:20
-
Oliver Hader merged patch set 2 06/15/22, 07:20