Review main Abandoned

74913[WIP][FEATURE] Add new Settings schema for extconf

crell CR 0 V 0 Nightmare +2650 −24 updated 02/04/23, 11:20

Commit message

This is a still-in-progress update of the Settings API.

This patch tries to integrate the new Settings.yaml file
and schema processing into the existing extconf pipeline,
so that it gets used for schema information in place of
ext_conf_template.txt if possible.  The data storage
and read/write is unaffected.

At this time, gentle feedback is welcome.

There is one workaround in AuthenticationStyleInformation.
The new Settings system, deliberately, does not have
missing values. Everything has a default value. However,
the existing login form logic shows a default button
color with a hover effect if no color is set, and a
custom color with no hover effect if a color is set.
That is enforced by an acceptance test. For the moment
the code hard-codes the default as a magic value to
not override the default behavior, to allow the test to
pass.  This is likely not the best long term solution,
but sufficient for now until we decide on a better
answer.

More of the Settings API is included than is currently
used. Further updates will make more use of them, once we
determine what the first round of changes will look like.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 67

Show 47 more files