Review main Abandoned

74919[BUGFIX] Unify translation source language resolving

Nikita Hovratov CR 0 V 0 Normal +118 −84 updated 07/29/23, 21:11

Commit message

This patch fixes the visibility of the translation button in the
translation view by unifying existing approaches.

In order to filter out already translated records, a list of default
language record uids was created and then checked against the parent
language of the translated record.

This worked fine for languages which have the default language as the
translation source. But if there are three or more languages with
different language sources, the uids to check against must come from
the appropriate language source.

Actually, this very question is already answered by the
LocalizationController and LocalizationRepository when resolving the
translated record uids. This part is now extracted into a new method
in the repository class and is used for both the controller and
ContentFetcher.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4